From: Jeremiah Mahler <jmmahler@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v2 linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning
Date: Sat, 9 Aug 2014 00:38:33 -0700 [thread overview]
Message-ID: <1407569913-4035-1-git-send-email-jmmahler@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1408081503270.15603@chino.kir.corp.google.com>
A sparse warning is generated about 'tlb_single_page_flush_ceiling'
not being declared.
arch/x86/mm/tlb.c:177:15: warning: symbol
'tlb_single_page_flush_ceiling' was not declared. Should it be static?
Since it isn't used anywhere outside this file, fix the warning by
making it static.
Also, optimize the use of this variable by adding the __read_mostly
directive.
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
Suggested-by: David Rientjes <rientjes@google.com>
---
Notes:
I like the suggestion from David Rientjes, to add __read_mostly.
Patch updated.
arch/x86/mm/tlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 1fe3398..bbe5766 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -174,7 +174,7 @@ void flush_tlb_current_task(void)
*
* This is in units of pages.
*/
-unsigned long tlb_single_page_flush_ceiling = 33;
+static unsigned long tlb_single_page_flush_ceiling __read_mostly = 33;
void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
unsigned long end, unsigned long vmflag)
--
2.1.0.rc1
next prev parent reply other threads:[~2014-08-09 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 7:24 [PATCH linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning Jeremiah Mahler
2014-08-08 22:03 ` David Rientjes
2014-08-09 7:38 ` Jeremiah Mahler [this message]
2014-08-10 7:46 ` [tip:x86/urgent] x86/mm: Fix sparse ' tlb_single_page_flush_ceiling' warning and make the variable read-mostly tip-bot for Jeremiah Mahler
2014-08-11 17:24 ` [PATCH v2 linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407569913-4035-1-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox