[PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

[PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

[Junien Fridrick]

Sorry for the noise, this is part of task 10 of the Eudyptula Challenge.

Signed-off-by: Junien Fridrick <linux.kernel@junien.fridrick.net>
---
 drivers/staging/lustre/lustre/llite/remote_perm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c b/drivers/staging/lustre/lustre/llite/remote_perm.c
index f61fefc..3a9c8e8 100644
--- a/drivers/staging/lustre/lustre/llite/remote_perm.c
+++ b/drivers/staging/lustre/lustre/llite/remote_perm.c
@@ -100,7 +100,7 @@ void free_rmtperm_hash(struct hlist_head *hash)
 	struct ll_remote_perm *lrp;
 	struct hlist_node *next;
 
-	if(!hash)
+	if (!hash)
 		return;
 
 	for (i = 0; i < REMOTE_PERM_HASHSIZE; i++)
-- 
2.0.1

Re: [PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

[Aaro Koskinen]

On Sat, Aug 09, 2014 at 08:22:48PM +0000, Junien Fridrick wrote:
> Sorry for the noise, this is part of task 10 of the Eudyptula Challenge.

Nothing wrong with the patch itself, but maybe in the future you could
put such comments after the "---" line so that they won't be included
in the git commit logs when the patch is applied (and will end
up being "noise").

A.

Re: [PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

[Greg Kroah-Hartman]

On Sat, Aug 09, 2014 at 08:22:48PM +0000, Junien Fridrick wrote:
> Sorry for the noise, this is part of task 10 of the Eudyptula Challenge.

It's not noise at all, but it's not needed in the changelog comment, as
was pointed out.

Can you resend without this line, and actually say _what_ coding style
change you made?  And drop all of the [ ] in the subject, except for the
[PATCH] part, that's not needed, just use ':' instead, so it would look
like:
	Subject: [PATCH] staging: lustre: fix...

thanks,

greg k-h

[PATCH v2] staging: lustre: fix coding style issue: missing space after 'if'

[Junien Fridrick]

Coding style issue reported by checkpatch.pl

Signed-off-by: Junien Fridrick <linux.kernel@junien.fridrick.net>
---
This patch is part of task 10 of the eudyptula challenge
Applies to next-20140808

v2 : fixed patch short summary and description

 drivers/staging/lustre/lustre/llite/remote_perm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c b/drivers/staging/lustre/lustre/llite/remote_perm.c
index f61fefc..3a9c8e8 100644
--- a/drivers/staging/lustre/lustre/llite/remote_perm.c
+++ b/drivers/staging/lustre/lustre/llite/remote_perm.c
@@ -100,7 +100,7 @@ void free_rmtperm_hash(struct hlist_head *hash)
 	struct ll_remote_perm *lrp;
 	struct hlist_node *next;
 
-	if(!hash)
+	if (!hash)
 		return;
 
 	for (i = 0; i < REMOTE_PERM_HASHSIZE; i++)
-- 
2.0.1