From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbaHOPKb (ORCPT ); Fri, 15 Aug 2014 11:10:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13847 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbaHOPK3 (ORCPT ); Fri, 15 Aug 2014 11:10:29 -0400 Subject: Re: [RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte From: Ewan Milne Reply-To: emilne@redhat.com To: Yoshihiro YUNOMAE Cc: Hannes Reinecke , linux-scsi@vger.kernel.org, "Martin K. Petersen" , yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Hidehiro Kawai , Doug Gilbert , Masami Hiramatsu , Christoph Hellwig In-Reply-To: <20140808115017.6768.74578.stgit@yuno-kbuild.novalocal> References: <20140808115004.6768.97014.stgit@yuno-kbuild.novalocal> <20140808115017.6768.74578.stgit@yuno-kbuild.novalocal> Content-Type: text/plain; charset="UTF-8" Organization: Red Hat Date: Fri, 15 Aug 2014 11:10:16 -0400 Message-ID: <1408115416.1223.149.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-08-08 at 11:50 +0000, Yoshihiro YUNOMAE wrote: > For getting driver byte, host byte, msg byte, and status byte, macros are > implemented in scsi/scsi.h, so we use it. > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Hannes Reinecke > Cc: Doug Gilbert > Cc: Martin K. Petersen > Cc: Christoph Hellwig > Cc: "James E.J. Bottomley" > Cc: Hidehiro Kawai > Cc: Masami Hiramatsu > --- > include/trace/events/scsi.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h > index db6c935..8aecdc2 100644 > --- a/include/trace/events/scsi.h > +++ b/include/trace/events/scsi.h > @@ -328,10 +328,10 @@ DECLARE_EVENT_CLASS(scsi_cmd_done_timeout_template, > show_opcode_name(__entry->opcode), > __parse_cdb(__get_dynamic_array(cmnd), __entry->cmd_len), > __print_hex(__get_dynamic_array(cmnd), __entry->cmd_len), > - show_driverbyte_name(((__entry->result) >> 24) & 0xff), > - show_hostbyte_name(((__entry->result) >> 16) & 0xff), > - show_msgbyte_name(((__entry->result) >> 8) & 0xff), > - show_statusbyte_name(__entry->result & 0xff)) > + show_driverbyte_name(driver_byte(__entry->result)), > + show_hostbyte_name(host_byte(__entry->result)), > + show_msgbyte_name(msg_byte(__entry->result)), > + show_statusbyte_name(status_byte(__entry->result))) > ); > > DEFINE_EVENT(scsi_cmd_done_timeout_template, scsi_dispatch_cmd_done, > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ (Based upon Hannes' logging tree...) Hannes, you should probably just update your tree with this. Reviewed-by: Ewan D. Milne