* [PATCH] kdb: Remove stack dump when entering kgdb due to NMI
@ 2014-07-16 13:40 Daniel Thompson
2014-08-18 15:09 ` [RESEND PATCH 3.17rc1] " Daniel Thompson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Thompson @ 2014-07-16 13:40 UTC (permalink / raw)
To: Jason Wessel
Cc: Daniel Thompson, linux-kernel, patches, linaro-kernel,
Mike Travis, Ingo Molnar, kgdb-bugreport
Issuing a stack dump feels ergonomically wrong when entering due to NMI.
Entering due to NMI is a normally reaction to a user request, either the
NMI button on a server or a "magic knock" on a UART. Therefore the
backtrace behaviour on entry due to NMI should be like SysRq-g (no stack
dump) rather than like oops.
Note also that the stack dump does not offer any information that
cannot be trivial retrieved using the 'bt' command.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: kgdb-bugreport@lists.sourceforge.net
---
kernel/debug/kdb/kdb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 49f2425..6d19905 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
kdb_printf("due to NonMaskable Interrupt @ "
kdb_machreg_fmt "\n",
instruction_pointer(regs));
- kdb_dumpregs(regs);
break;
case KDB_REASON_SSTEP:
case KDB_REASON_BREAK:
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RESEND PATCH 3.17rc1] kdb: Remove stack dump when entering kgdb due to NMI
2014-07-16 13:40 [PATCH] kdb: Remove stack dump when entering kgdb due to NMI Daniel Thompson
@ 2014-08-18 15:09 ` Daniel Thompson
2014-11-06 15:33 ` [RESEND PATCH v3.18-rc3] " Daniel Thompson
2015-01-07 15:42 ` [RESEND PATCH v3.19-rc2] " Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2014-08-18 15:09 UTC (permalink / raw)
To: Jason Wessel
Cc: Daniel Thompson, linux-kernel, patches, linaro-kernel,
Mike Travis, Ingo Molnar, kgdb-bugreport
Issuing a stack dump feels ergonomically wrong when entering due to NMI.
Entering due to NMI is a normally reaction to a user request, either the
NMI button on a server or a "magic knock" on a UART. Therefore the
backtrace behaviour on entry due to NMI should be like SysRq-g (no stack
dump) rather than like oops.
Note also that the stack dump does not offer any information that
cannot be trivial retrieved using the 'bt' command.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: kgdb-bugreport@lists.sourceforge.net
---
kernel/debug/kdb/kdb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 379650b..f9ba423 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
kdb_printf("due to NonMaskable Interrupt @ "
kdb_machreg_fmt "\n",
instruction_pointer(regs));
- kdb_dumpregs(regs);
break;
case KDB_REASON_SSTEP:
case KDB_REASON_BREAK:
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RESEND PATCH v3.18-rc3] kdb: Remove stack dump when entering kgdb due to NMI
2014-07-16 13:40 [PATCH] kdb: Remove stack dump when entering kgdb due to NMI Daniel Thompson
2014-08-18 15:09 ` [RESEND PATCH 3.17rc1] " Daniel Thompson
@ 2014-11-06 15:33 ` Daniel Thompson
2015-01-07 15:42 ` [RESEND PATCH v3.19-rc2] " Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2014-11-06 15:33 UTC (permalink / raw)
To: Jason Wessel
Cc: Daniel Thompson, linux-kernel, kgdb-bugreport, Andrew Morton,
Ingo Molnar, patches, linaro-kernel, John Stultz, Sumit Semwal
Issuing a stack dump feels ergonomically wrong when entering due to NMI.
Entering due to NMI is normally a reaction to a user request, either the
NMI button on a server or a "magic knock" on a UART. Therefore the
backtrace behaviour on entry due to NMI should be like SysRq-g (no stack
dump) rather than like oops.
Note also that the stack dump does not offer any information that
cannot be trivial retrieved using the 'bt' command.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
---
kernel/debug/kdb/kdb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 379650b..f9ba423 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
kdb_printf("due to NonMaskable Interrupt @ "
kdb_machreg_fmt "\n",
instruction_pointer(regs));
- kdb_dumpregs(regs);
break;
case KDB_REASON_SSTEP:
case KDB_REASON_BREAK:
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RESEND PATCH v3.19-rc2] kdb: Remove stack dump when entering kgdb due to NMI
2014-07-16 13:40 [PATCH] kdb: Remove stack dump when entering kgdb due to NMI Daniel Thompson
2014-08-18 15:09 ` [RESEND PATCH 3.17rc1] " Daniel Thompson
2014-11-06 15:33 ` [RESEND PATCH v3.18-rc3] " Daniel Thompson
@ 2015-01-07 15:42 ` Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2015-01-07 15:42 UTC (permalink / raw)
To: Jason Wessel
Cc: Daniel Thompson, linux-kernel, kgdb-bugreport, Andrew Morton,
Ingo Molnar, patches, linaro-kernel, John Stultz, Sumit Semwal
Issuing a stack dump feels ergonomically wrong when entering due to NMI.
Entering due to NMI is normally a reaction to a user request, either the
NMI button on a server or a "magic knock" on a UART. Therefore the
backtrace behaviour on entry due to NMI should be like SysRq-g (no stack
dump) rather than like oops.
Note also that the stack dump does not offer any information that
cannot be trivial retrieved using the 'bt' command.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
---
kernel/debug/kdb/kdb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 379650b984f8..f9ba42363132 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
kdb_printf("due to NonMaskable Interrupt @ "
kdb_machreg_fmt "\n",
instruction_pointer(regs));
- kdb_dumpregs(regs);
break;
case KDB_REASON_SSTEP:
case KDB_REASON_BREAK:
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-07 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-16 13:40 [PATCH] kdb: Remove stack dump when entering kgdb due to NMI Daniel Thompson
2014-08-18 15:09 ` [RESEND PATCH 3.17rc1] " Daniel Thompson
2014-11-06 15:33 ` [RESEND PATCH v3.18-rc3] " Daniel Thompson
2015-01-07 15:42 ` [RESEND PATCH v3.19-rc2] " Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).