* [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv
@ 2014-08-20 2:04 Axel Lin
2014-08-20 15:21 ` Mark Brown
2014-08-20 16:10 ` Javier Martinez Canillas
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-08-20 2:04 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Javier Martinez Canillas, Naveen Krishna Chatradhi,
linux-kernel@vger.kernel.org
Both num_regulators and *rdev[MAX77802_REG_MAX] are not used, remove them.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/max77802.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c
index 5f022f8..ad1caa9 100644
--- a/drivers/regulator/max77802.c
+++ b/drivers/regulator/max77802.c
@@ -65,8 +65,6 @@ static unsigned int ramp_table_77802_4bit[] = {
};
struct max77802_regulator_prv {
- int num_regulators;
- struct regulator_dev *rdev[MAX77802_REG_MAX];
unsigned int opmode[MAX77802_REG_MAX];
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv
2014-08-20 2:04 [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv Axel Lin
@ 2014-08-20 15:21 ` Mark Brown
2014-08-20 16:10 ` Javier Martinez Canillas
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-08-20 15:21 UTC (permalink / raw)
To: Axel Lin
Cc: Liam Girdwood, Javier Martinez Canillas, Naveen Krishna Chatradhi,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
On Wed, Aug 20, 2014 at 10:04:17AM +0800, Axel Lin wrote:
> Both num_regulators and *rdev[MAX77802_REG_MAX] are not used, remove them.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv
2014-08-20 2:04 [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv Axel Lin
2014-08-20 15:21 ` Mark Brown
@ 2014-08-20 16:10 ` Javier Martinez Canillas
1 sibling, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2014-08-20 16:10 UTC (permalink / raw)
To: Axel Lin, Mark Brown
Cc: Liam Girdwood, Naveen Krishna Chatradhi,
linux-kernel@vger.kernel.org
Hello Axel,
On 08/20/2014 04:04 AM, Axel Lin wrote:
> Both num_regulators and *rdev[MAX77802_REG_MAX] are not used, remove them.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Right, these are not used indeed since are left overs from the previous
attempt to have a single driver for both max77686 and max77802 PMICs.
Sorry about that and thanks a lot for the patch.
>
> struct max77802_regulator_prv {
> - int num_regulators;
> - struct regulator_dev *rdev[MAX77802_REG_MAX];
> unsigned int opmode[MAX77802_REG_MAX];
> };
>
>
I see that Mark already applied this but fwiw:
Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-20 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-20 2:04 [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv Axel Lin
2014-08-20 15:21 ` Mark Brown
2014-08-20 16:10 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).