From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbaHTJcG (ORCPT ); Wed, 20 Aug 2014 05:32:06 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:48678 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbaHTJcD (ORCPT ); Wed, 20 Aug 2014 05:32:03 -0400 From: Zhu Yanjun X-Google-Original-From: Zhu Yanjun To: dborkman@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vyasevich@gmail.com, tuexen@fh-muenster.de, khandelwal.deepak.1987@gmail.com, Yue.Tao@windriver.com, alexandre.dietsch@windriver.com, davem@davemloft.net, zyjzyj2000@gmail.com Cc: Zhu Yanjun Subject: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe Date: Wed, 20 Aug 2014 17:31:43 +0800 Message-Id: <1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408527103-22772-1-git-send-email-Yanjun.Zhu@windriver.com> References: <1408527103-22772-1-git-send-email-Yanjun.Zhu@windriver.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the transport has always been in state SCTP_UNCONFIRMED, it therefore wasn't active before and hasn't been used before, and it always has been, so it is unnecessary to bug the user with a notification. Reported-by: Deepak Khandelwal Suggested-by: Vlad Yasevich Suggested-by: Michael Tuexen Suggested-by: Daniel Borkmann Signed-off-by: Zhu Yanjun --- net/sctp/associola.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 9de23a2..2e23f6b 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, else { dst_release(transport->dst); transport->dst = NULL; + ulp_notify = false; } spc_state = SCTP_ADDR_UNREACHABLE; -- 1.9.1