linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	Raghavendra KT <raghavendra.kt@linux.vnet.ibm.com>,
	Vinod Chegu <chegu_vinod@hp.com>, Hui-Zhi <hui-zhi.zhao@hp.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [PATCH v2 5/6] KVM: trace kvm_ple_window
Date: Wed, 20 Aug 2014 22:53:16 +0200	[thread overview]
Message-ID: <1408567997-21222-6-git-send-email-rkrcmar@redhat.com> (raw)
In-Reply-To: <1408567997-21222-1-git-send-email-rkrcmar@redhat.com>

Tracepoint for dynamic PLE window, fired on every potential change.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 arch/x86/kvm/trace.h | 25 +++++++++++++++++++++++++
 arch/x86/kvm/vmx.c   |  8 +++++---
 arch/x86/kvm/x86.c   |  1 +
 3 files changed, 31 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
index e850a7d..4b8e6cb 100644
--- a/arch/x86/kvm/trace.h
+++ b/arch/x86/kvm/trace.h
@@ -848,6 +848,31 @@ TRACE_EVENT(kvm_track_tsc,
 		  __print_symbolic(__entry->host_clock, host_clocks))
 );
 
+TRACE_EVENT(kvm_ple_window,
+	TP_PROTO(int grow, unsigned int vcpu_id, int new, int old),
+	TP_ARGS(grow, vcpu_id, new, old),
+
+	TP_STRUCT__entry(
+		__field(                 int,      grow         )
+		__field(        unsigned int,   vcpu_id         )
+		__field(                 int,       new         )
+		__field(                 int,       old         )
+	),
+
+	TP_fast_assign(
+		__entry->grow           = grow;
+		__entry->vcpu_id        = vcpu_id;
+		__entry->new            = new;
+		__entry->old            = old;
+	),
+
+	TP_printk("vcpu %u: ple_window %d %s %d",
+	          __entry->vcpu_id,
+	          __entry->new,
+	          __entry->grow ? "<+" : "<-",
+	          __entry->old)
+);
+
 #endif /* CONFIG_X86_64 */
 
 #endif /* _TRACE_KVM_H */
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index e63d7ac..f63ac5d 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -5728,15 +5728,17 @@ static int __shrink_ple_window(int val, int shrinker, int minimum)
 static void modify_ple_window(struct kvm_vcpu *vcpu, int grow)
 {
 	struct vcpu_vmx *vmx = to_vmx(vcpu);
+	int old = vmx->ple_window;
 	int new;
 
 	if (grow)
-		new = __grow_ple_window(vmx->ple_window);
+		new = __grow_ple_window(old)
 	else
-		new = __shrink_ple_window(vmx->ple_window, ple_window_shrink,
-		                          ple_window);
+		new = __shrink_ple_window(old, ple_window_shrink, ple_window);
 
 	vmx->ple_window = max(new, ple_window);
+
+	trace_kvm_ple_window(grow, vcpu->vcpu_id, vmx->ple_window, old);
 }
 #define grow_ple_window(vcpu)   modify_ple_window(vcpu, 1)
 #define shrink_ple_window(vcpu) modify_ple_window(vcpu, 0)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 5696ee7..814b20c 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7648,3 +7648,4 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_invlpga);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_skinit);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_intercepts);
 EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_write_tsc_offset);
+EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_ple_window);
-- 
2.0.4


  parent reply	other threads:[~2014-08-20 20:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 20:53 [PATCH v2 0/6] Dynamic Pause Loop Exiting window Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 1/6] KVM: add kvm_arch_sched_in Radim Krčmář
2014-08-21  8:29   ` Paolo Bonzini
2014-08-21 11:38     ` Radim Krčmář
2014-08-21 12:27       ` Paolo Bonzini
2014-08-21 12:50         ` Radim Krčmář
2014-08-21 13:25           ` Paolo Bonzini
2014-08-20 20:53 ` [PATCH v2 2/6] KVM: x86: introduce sched_in to kvm_x86_ops Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 3/6] KVM: VMX: make PLE window per-VCPU Radim Krčmář
2014-08-21  8:25   ` Paolo Bonzini
2014-08-21 11:38     ` Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 4/6] KVM: VMX: dynamise PLE window Radim Krčmář
2014-08-21  8:24   ` Paolo Bonzini
2014-08-21 11:47     ` Radim Krčmář
2014-08-21  8:26   ` Paolo Bonzini
2014-08-21 11:54     ` Radim Krčmář
2014-08-21 12:29       ` Paolo Bonzini
2014-08-21 12:42         ` Radim Krčmář
2014-08-21 13:18           ` Paolo Bonzini
2014-08-21 13:46             ` Radim Krčmář
2014-08-20 20:53 ` Radim Krčmář [this message]
2014-08-21  8:29   ` [PATCH v2 5/6] KVM: trace kvm_ple_window Paolo Bonzini
2014-08-21 11:56     ` Radim Krčmář
2014-08-21 13:22       ` Paolo Bonzini
2014-08-21 13:49         ` Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 6/6] KVM: VMX: runtime knobs for dynamic PLE window Radim Krčmář
2014-08-21  6:49 ` [PATCH v2 0/6] Dynamic Pause Loop Exiting window Zhao, Hui-Zhi (Steven, HPservers-Core-OE-PSC)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408567997-21222-6-git-send-email-rkrcmar@redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chegu_vinod@hp.com \
    --cc=gleb@kernel.org \
    --cc=hui-zhi.zhao@hp.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).