From: Pawel Moll <pawel.moll@arm.com>
To: Alex Shi <alex.shi@linaro.org>, arm@kernel.org
Cc: Sudeep Holla <Sudeep.Holla@arm.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"nico@linaro.org" <nico@linaro.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.brown@linaro.org" <mark.brown@linaro.org>,
"tixy@linaro.org" <tixy@linaro.org>
Subject: Re: [PATCH] vexpress/spc: fix a build warning on array bounds
Date: Thu, 28 Aug 2014 21:00:59 -0700 [thread overview]
Message-ID: <1409284859.25020.3.camel@rojo> (raw)
In-Reply-To: <53FFDB50.3060904@linaro.org>
On pią, 2014-08-29 at 02:45 +0100, Alex Shi wrote:
> On 07/16/2014 07:28 PM, Sudeep Holla wrote:
> >
> >
> > On 16/07/14 12:21, Alex Shi wrote:
> >> With ARCH_VEXPRESS_SPC option, kernel build has the following
> >> warning:
> >>
> >> arch/arm/mach-vexpress/spc.c: In function ‘ve_spc_clk_init’:
> >> arch/arm/mach-vexpress/spc.c:431:38: warning: array subscript is below
> >> array bounds [-Warray-bounds]
> >> struct ve_spc_opp *opps = info->opps[cluster];
> >> ^
> >> since 'cluster' maybe '-1' in UP system. This patch does a active
> >> checking to fix this issue.
> >>
> >
> > Good catch, looks fine to me.
> >
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Anyone like to pick up this build warning fix? Or comments are appreciated!
My fault, sorry, forgot about it...
Acked-by: Pawel Moll <pawel.moll@arm.com>
Arnd, Olof, could you please queue it as a fix? Happy to push a branch
if you wish.
Thanks!
Pawel
next prev parent reply other threads:[~2014-08-29 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 11:21 [PATCH] vexpress/spc: fix a build warning on array bounds Alex Shi
2014-07-16 11:28 ` Sudeep Holla
2014-08-29 1:45 ` Alex Shi
2014-08-29 4:00 ` Pawel Moll [this message]
2014-08-31 17:23 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409284859.25020.3.camel@rojo \
--to=pawel.moll@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=alex.shi@linaro.org \
--cc=arm@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.brown@linaro.org \
--cc=nico@linaro.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tixy@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox