* [PATCH] powercap/rapl: lower warning level for domain detection
@ 2014-08-29 4:56 Jacob Pan
2014-09-01 23:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Pan @ 2014-08-29 4:56 UTC (permalink / raw)
To: Rafael Wysocki, Linux PM; +Cc: Srinivas Pandruvada, LKML, Jacob Pan
Many CPUs do not support complete set of RAPL domains, as a
result this detection failed message is very misleading and
annoying. So lower the warning message to info and reword.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
drivers/powercap/intel_rapl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b1cda6f..0b282e7 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
if (!rapl_check_domain(cpu, i))
rp->domain_map |= 1 << i;
else
- pr_warn("RAPL domain %s detection failed\n",
+ pr_info("RAPL domain %s not supported\n",
rapl_domain_names[i]);
}
rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
--
2.0.0.5.gbce14aa
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powercap/rapl: lower warning level for domain detection
2014-08-29 4:56 [PATCH] powercap/rapl: lower warning level for domain detection Jacob Pan
@ 2014-09-01 23:48 ` Rafael J. Wysocki
2014-09-02 17:57 ` Jacob Pan
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-09-01 23:48 UTC (permalink / raw)
To: Jacob Pan; +Cc: Rafael Wysocki, Linux PM, Srinivas Pandruvada, LKML
On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote:
> Many CPUs do not support complete set of RAPL domains, as a
> result this detection failed message is very misleading and
> annoying. So lower the warning message to info and reword.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
What about printing a (info-level) message if the RAPL domain *is*
supported? That surely is more interesting?
> ---
> drivers/powercap/intel_rapl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index b1cda6f..0b282e7 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
> if (!rapl_check_domain(cpu, i))
> rp->domain_map |= 1 << i;
> else
> - pr_warn("RAPL domain %s detection failed\n",
> + pr_info("RAPL domain %s not supported\n",
> rapl_domain_names[i]);
> }
> rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powercap/rapl: lower warning level for domain detection
2014-09-01 23:48 ` Rafael J. Wysocki
@ 2014-09-02 17:57 ` Jacob Pan
0 siblings, 0 replies; 3+ messages in thread
From: Jacob Pan @ 2014-09-02 17:57 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Rafael Wysocki, Linux PM, Srinivas Pandruvada, LKML
On Tue, 02 Sep 2014 01:48:40 +0200
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote:
> > Many CPUs do not support complete set of RAPL domains, as a
> > result this detection failed message is very misleading and
> > annoying. So loweab Pan <jacob.jun.pan@linux.intel.com>
>
> What about printing a (info-level) message if the RAPL domain *is*
> supported? That surely is more interesting?
>
yes, that is better. just sent out an updated patch with a different
Subject: [PATCH] powercap/rapl: change domain detection message
Thanks,
Jacob
> > ---
> > drivers/powercap/intel_rapl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/powercap/intel_rapl.c
> > b/drivers/powercap/intel_rapl.c index b1cda6f..0b282e7 100644
> > --- a/drivers/powercap/intel_rapl.c
> > +++ b/drivers/powercap/intel_rapl.c
> > @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct
> > rapl_package *rp, int cpu) if (!rapl_check_domain(cpu, i))
> > rp->domain_map |= 1 << i;
> > else
> > - pr_warn("RAPL domain %s detection
> > failed\n",
> > + pr_info("RAPL domain %s not supported\n",
> > rapl_domain_names[i]);
> > }
> > rp->nr_domains = bitmap_weight(&rp->domain_map,
> > RAPL_DOMAIN_MAX);
> >
>
[Jacob Pan]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-02 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 4:56 [PATCH] powercap/rapl: lower warning level for domain detection Jacob Pan
2014-09-01 23:48 ` Rafael J. Wysocki
2014-09-02 17:57 ` Jacob Pan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox