From: Ramon Fried <ramon.fried@gmail.com>
To: ramon.fried@gmail.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Daniel Borkmann <dborkman@redhat.com>,
Alan Cox <alan@linux.intel.com>,
Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de>,
Mostyn Bramley-Moore <mbmcode@gmail.com>,
Toby Smith <toby@tismith.id.au>,
Archana kumari <archanakumari959@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Himangi Saraogi <himangi774@gmail.com>,
Iulia Manda <iulia.manda21@gmail.com>,
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings
Date: Sun, 31 Aug 2014 03:16:48 +0300 [thread overview]
Message-ID: <1409444211-758-1-git-send-email-ramon.fried@gmail.com> (raw)
This patch fixes the following checkpatch.pl warnings:
WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+ if (!skb) {
+ pr_err("SKB allocation failed\n");
WARNING: Missing a blank line after declarations
#1107: FILE: ./xlr_net.c:1107:
+ struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+ unregister_netdev(priv->ndev);
Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
---
drivers/staging/netlogic/xlr_net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
index 9bf407d..28a42831 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
/* skb->data is cache aligned */
skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
- if (!skb) {
- pr_err("SKB allocation failed\n");
+ if (!skb)
return NULL;
- }
mac_put_skb_back_ptr(skb);
return skb;
}
@@ -1104,6 +1102,7 @@ err_gmac:
static int xlr_net_remove(struct platform_device *pdev)
{
struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
unregister_netdev(priv->ndev);
mdiobus_unregister(priv->mii_bus);
mdiobus_free(priv->mii_bus);
--
1.9.1
next reply other threads:[~2014-08-31 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 0:16 Ramon Fried [this message]
2014-08-31 0:32 ` [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2014-08-31 7:24 Ramon Fried
2014-08-30 19:54 Ramon Fried
2014-08-30 21:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409444211-758-1-git-send-email-ramon.fried@gmail.com \
--to=ramon.fried@gmail.com \
--cc=alan@linux.intel.com \
--cc=archanakumari959@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=iulia.manda21@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbmcode@gmail.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=toby@tismith.id.au \
--cc=w-lkml@lebenslange-mailadresse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox