Re: [PATCH v3 07/11] wireless: hostap: proc: print properly escaped SSID

Andy Shevchenko
2014-09-01T07:16:29Z

On Wed, 2014-08-20 at 12:42 +0300, Andy Shevchenko wrote:
> Instead of substituting non-printable characters by '_' let's print SSID
> properly escaped by using recently added %*pE specifier.

Here is kbuild robot fixup.

>From f88ff364a1b117d3c86186206eeaa54ff906147a Mon Sep 17 00:00:00 2001
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon, 1 Sep 2014 10:13:28 +0300
Subject: [PATCH] wireless: hostap: kbuild robot fixup

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/wireless/hostap/hostap_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/hostap/hostap_proc.c
b/drivers/net/wireless/hostap/hostap_proc.c
index 16a06b6..5b1a510 100644
--- a/drivers/net/wireless/hostap/hostap_proc.c
+++ b/drivers/net/wireless/hostap/hostap_proc.c
@@ -181,7 +181,7 @@ static int prism2_bss_list_proc_show(struct seq_file
*m, void *v)
bss->bssid, bss->last_update,
bss->count, bss->capab_info);

- seq_printf(m, "%*pE", bss->ssid_len, bss->ssid);
+ seq_printf(m, "%*pE", (int)bss->ssid_len, bss->ssid);

seq_putc(m, '\t');
for (i = 0; i < bss->ssid_len; i++)
--
2.1.0

>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/wireless/hostap/hostap_proc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> index 4e5c0f8..16a06b6 100644
> --- a/drivers/net/wireless/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/hostap/hostap_proc.c
> @@ -181,9 +181,7 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
> bss->bssid, bss->last_update,
> bss->count, bss->capab_info);
>
> - for (i = 0; i < bss->ssid_len; i++)
> - seq_putc(m,bss->ssid[i] >= 32 && bss->ssid[i] < 127 ?
> - bss->ssid[i] : '_');
> + seq_printf(m, "%*pE", bss->ssid_len, bss->ssid);
>
> seq_putc(m, '\t');
> for (i = 0; i < bss->ssid_len; i++)

--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy