Re: [PATCH v3 00/11] lib: introduce string_escape_mem and %*pE specifier

Andrew Morton
2014-08-28T21:06:57Z

On Thu, 28 Aug 2014 23:58:45 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Thu, Aug 28, 2014 at 10:08 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville" <linville@tuxdriver.com> wrote:
> >
> >> On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevchenko wrote:
> >> > The introduced function is a kind of opposite to string_unescape. We have
> >> > several users of such functionality each of them created custom implementation.
> >> > The series contains clean up of test suite, adding new call, and switching few
> >> > users to use it via %*pE specifier.
> >>
> >> Any objections? Do you (Andy) want me to merge this through the
> >> wireless tree?
> >>
> >
> > Who is this top-poster and what have you done with John?
> >
> > I was going to apply them yesterday but in [4/11] Andy said he plans on
> > sending out a v5. (v4 actually?)
>
> For now (so far no more comments) it is only couple of trivia fixes
> (removing useless comments). Would you like to resend whole series or
> just fixup would be enough?

I fixed up the one Joe commented on.

--- a/lib/vsprintf.c~lib-vsprintf-add-%pe-format-specifier-fix
+++ a/lib/vsprintf.c
@@ -1111,12 +1111,11 @@ char *escaped_string(char *buf, char *en
int len;

if (spec.field_width == 0)
- /* nothing to print */
- return buf;
+ return buf; /* nothing to print */

if (ZERO_OR_NULL_PTR(addr))
- /* NULL pointer */
- return string(buf, end, NULL, spec);
+ return string(buf, end, NULL, spec); /* NULL pointer */
+

do {
switch (fmt[count++]) {
_