Re: [PATCH v3 5/5] [S390] zcrypt: use seq_hex_dump() to dump buffers

Ingo Tuchscherer
2014-08-27T13:26:44Z

[-- Attachment #1: Type: text/plain, Size: 4879 bytes --]

I have verified and tested the patch for the zcrypt part.
OK from my side. You can add my Acked-by.
Acked-by: Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>

Thanks

Mit freundlichen Grüßen / Kind regards

Ingo Tuchscherer

Software Development - Linux on System z
IBM Systems &Technology Group

Phone: +49-7031-16-1986 IBM Deutschland (Embedded
image moved
to file:
pic53004.gif)

E-Mail: ingo.tuchscherer@de.ibm.com Schoenaicher Str. 220

71032 Boeblingen

Germany

IBM Deutschland
Research &
Development
GmbH /
Vorsitzender des
Aufsichtsrats:
Martina Koederitz

Geschäftsführung:
Dirk Wittkopp
Sitz der
Gesellschaft:
Böblingen /
Registergericht:
Amtsgericht
Stuttgart, HRB
243294

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>, Herbert Xu
<herbert@gondor.apana.org.au>, Mauro Carvalho Chehab
<m.chehab@samsung.com>, Helge Deller <deller@gmx.de>, Ingo
Tuchscherer/Germany/IBM@IBMDE, Alexander Viro
<viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org, Joe
Perches <joe@perches.com>, Marek Vasut <marex@denx.de>,
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 08/25/2014 11:03 AM
Subject: [PATCH v3 5/5] [S390] zcrypt: use seq_hex_dump() to dump
buffers

Instead of custom approach let's use recently introduced seq_hex_dump()
helper.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/s390/crypto/zcrypt_api.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/s390/crypto/zcrypt_api.c
b/drivers/s390/crypto/zcrypt_api.c
index 0e18c5d..d1f9983 100644
--- a/drivers/s390/crypto/zcrypt_api.c
+++ b/drivers/s390/crypto/zcrypt_api.c
@@ -1203,16 +1203,8 @@ static void sprinthx(unsigned char *title, struct
seq_file *m,
static void sprinthx4(unsigned char *title, struct seq_file *m,
unsigned int *array, unsigned int len)
{
- int r;
-
seq_printf(m, "\n%s\n", title);
- for (r = 0; r < len; r++) {
- if ((r % 8) == 0)
- seq_printf(m, " ");
- seq_printf(m, "%08X ", array[r]);
- if ((r % 8) == 7)
- seq_putc(m, '\n');
- }
+ seq_hex_dump(m, " ", DUMP_PREFIX_NONE, 32, 4, array, len,
false);
seq_putc(m, '\n');
}

--
2.1.0

[-- Attachment #2: pic53004.gif --]
[-- Type: image/gif, Size: 1851 bytes --]