From: Joe Perches <joe@perches.com>
To: sunwxg <sun.wxg@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
"John L. Hammond" <john.hammond@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Chi Pham <fempsci@gmail.com>, Oleg Drokin <green@linuxhacker.ru>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: lov_pack: fix coding style issue
Date: Mon, 01 Sep 2014 09:26:19 -0700 [thread overview]
Message-ID: <1409588779.2614.2.camel@joe-AO725> (raw)
In-Reply-To: <1409586755-805-2-git-send-email-sun.wxg@gmail.com>
On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote:
> Fix the style error checking by checkpatch.pl
> ERROR: space required after that ','
[]
> diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
[]
> @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
> void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
> {
> lov_dump_lmm_common(level, lmm);
> - CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
> + CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
I think it better to separate the pre-coalesced
bits of the string like:
"pool name " LOV_POOLNAMEF "\n",
next prev parent reply other threads:[~2014-09-01 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:52 [PATCH] staging: lustre: lov_pack: fix coding style issue sunwxg
2014-09-01 16:26 ` Joe Perches [this message]
2014-09-02 17:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409588779.2614.2.camel@joe-AO725 \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dulshani.gunawardhana89@gmail.com \
--cc=fempsci@gmail.com \
--cc=green@linuxhacker.ru \
--cc=gregkh@linuxfoundation.org \
--cc=john.hammond@intel.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sun.wxg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox