From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Helge Deller <deller@gmx.de>,
Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Marek Vasut <marex@denx.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
Benjamin Romer <benjamin.romer@unisys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v4 06/12] saa7164: convert to seq_hex_dump()
Date: Thu, 4 Sep 2014 17:26:53 +0300 [thread overview]
Message-ID: <1409840819-18976-7-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1409840819-18976-1-git-send-email-andriy.shevchenko@linux.intel.com>
Instead of custom approach let's use recently added seq_hex_dump() helper.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Steven Toth <stoth@kernellabs.com>
Acked-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
---
drivers/media/pci/saa7164/saa7164-core.c | 31 ++++---------------------------
1 file changed, 4 insertions(+), 27 deletions(-)
diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c
index 1bf0697..6f81584 100644
--- a/drivers/media/pci/saa7164/saa7164-core.c
+++ b/drivers/media/pci/saa7164/saa7164-core.c
@@ -1065,7 +1065,6 @@ static int saa7164_proc_show(struct seq_file *m, void *v)
struct saa7164_dev *dev;
struct tmComResBusInfo *b;
struct list_head *list;
- int i, c;
if (saa7164_devcount == 0)
return 0;
@@ -1089,35 +1088,13 @@ static int saa7164_proc_show(struct seq_file *m, void *v)
seq_printf(m, " .m_pdwGetReadPos = 0x%x (0x%08x)\n",
b->m_dwGetWritePos, saa7164_readl(b->m_dwGetWritePos));
- c = 0;
seq_printf(m, "\n Set Ring:\n");
- seq_printf(m, "\n addr 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n");
- for (i = 0; i < b->m_dwSizeSetRing; i++) {
- if (c == 0)
- seq_printf(m, " %04x:", i);
+ seq_hex_dump(m, " ", DUMP_PREFIX_OFFSET, 16, 1,
+ b->m_pdwSetRing, b->m_dwSizeSetRing, false);
- seq_printf(m, " %02x", *(b->m_pdwSetRing + i));
-
- if (++c == 16) {
- seq_printf(m, "\n");
- c = 0;
- }
- }
-
- c = 0;
seq_printf(m, "\n Get Ring:\n");
- seq_printf(m, "\n addr 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n");
- for (i = 0; i < b->m_dwSizeGetRing; i++) {
- if (c == 0)
- seq_printf(m, " %04x:", i);
-
- seq_printf(m, " %02x", *(b->m_pdwGetRing + i));
-
- if (++c == 16) {
- seq_printf(m, "\n");
- c = 0;
- }
- }
+ seq_hex_dump(m, " ", DUMP_PREFIX_OFFSET, 16, 1,
+ b->m_pdwGetRing, b->m_dwSizeGetRing, false);
mutex_unlock(&b->lock);
--
2.1.0
next prev parent reply other threads:[~2014-09-04 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:26 [PATCH v4 00/12] fs/seq_file: introduce seq_hex_dump() helper Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 01/12] hexdump: introduce test suite Andy Shevchenko
2014-09-05 9:37 ` Geert Uytterhoeven
2014-09-05 12:39 ` Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 02/12] hexdump: fix ascii column for the tail of a dump Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 03/12] hexdump: do few calculations ahead Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 04/12] hexdump: makes it return amount of bytes placed in buffer Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 05/12] seq_file: provide an analogue of print_hex_dump() Andy Shevchenko
2014-09-16 7:11 ` Andy Shevchenko
2014-09-04 14:26 ` Andy Shevchenko [this message]
2014-09-04 14:26 ` [PATCH v4 07/12] crypto: qat - use seq_hex_dump() to dump buffers Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 08/12] parisc: " Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 09/12] [S390] zcrypt: " Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 10/12] staging: unisys: " Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 11/12] kmemleak: " Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 12/12] wil6210: " Andy Shevchenko
2014-10-22 15:48 ` [PATCH v4 00/12] fs/seq_file: introduce seq_hex_dump() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409840819-18976-7-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.romer@unisys.com \
--cc=catalin.marinas@arm.com \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=ingo.tuchscherer@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=marex@denx.de \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=rdunlap@infradead.org \
--cc=tadeusz.struk@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox