From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: ak@linux.intel.com, mingo@redhat.com, whissi@whissi.de,
dyoung@redhat.com, tglx@linutronix.de, vgoyal@redhat.com,
keescook@chromium.org, chaowang@redhat.com,
Baoquan He <bhe@redhat.com>
Subject: [PATCH 3/4] kaslr setup_data handling
Date: Fri, 5 Sep 2014 22:08:16 +0800 [thread overview]
Message-ID: <1409926097-2101-4-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1409926097-2101-1-git-send-email-bhe@redhat.com>
From: Dave Young <dyoung@redhat.com>
X86 will pass setup_data region while necessary, these regions could be
overwitten by kernel due to kaslr.
Thus iterate and add setup regions to mem_avoid[] in this patch.
Up to now there isn't a official data to state the maximal entries
setup data could use. So just set max mem avoid entries 32, hopefully
it will be enough. This can be increased later when people report
they are using more setup data entries.
Signed-off-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/boot/compressed/aslr.c | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c
index 975b07b..7e92fc8 100644
--- a/arch/x86/boot/compressed/aslr.c
+++ b/arch/x86/boot/compressed/aslr.c
@@ -110,8 +110,9 @@ struct mem_vector {
unsigned long size;
};
-#define MEM_AVOID_MAX 5
+#define MEM_AVOID_MAX 32
static struct mem_vector mem_avoid[MEM_AVOID_MAX];
+static int mem_avoid_nr;
static bool mem_contains(struct mem_vector *region, struct mem_vector *item)
{
@@ -135,6 +136,27 @@ static bool mem_overlaps(struct mem_vector *one, struct mem_vector *two)
return true;
}
+static void mem_avoid_setup_data(void)
+{
+ struct setup_data *data;
+ u64 pa_data;
+
+ pa_data = real_mode->hdr.setup_data;
+ while (pa_data) {
+ if (mem_avoid_nr >= MEM_AVOID_MAX) {
+ debug_putstr("KASLR: too many setup_data ranges.\n");
+ return;
+ }
+ data = (struct setup_data *)pa_data;
+ if (pa_data < CONFIG_RANDOMIZE_BASE_MAX_OFFSET) {
+ mem_avoid[mem_avoid_nr].start = pa_data;
+ mem_avoid[mem_avoid_nr].size = sizeof(*data) + data->len;
+ mem_avoid_nr++;
+ }
+ pa_data = data->next;
+ }
+}
+
static void mem_avoid_init(unsigned long input, unsigned long input_size,
unsigned long output, unsigned long output_size)
{
@@ -177,6 +199,9 @@ static void mem_avoid_init(unsigned long input, unsigned long input_size,
/* Avoid stack memory. */
mem_avoid[4].start = (unsigned long)free_mem_end_ptr;
mem_avoid[4].size = BOOT_STACK_SIZE;
+ mem_avoid_nr = 5;
+
+ mem_avoid_setup_data();
}
/* Does this memory vector overlap a known avoided area? */
@@ -184,7 +209,7 @@ static bool mem_avoid_overlap(struct mem_vector *img)
{
int i;
- for (i = 0; i < MEM_AVOID_MAX; i++) {
+ for (i = 0; i < mem_avoid_nr; i++) {
if (mem_overlaps(img, &mem_avoid[i]))
return true;
}
--
1.8.5.3
next prev parent reply other threads:[~2014-09-05 14:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:08 [PATCH 0/4] fix the compatibility between kaslr and kexe Baoquan He
2014-09-05 14:08 ` [PATCH 1/4] kaslr: check user's config too when handle relocations Baoquan He
2014-09-05 17:11 ` Kees Cook
2014-09-05 22:37 ` Baoquan He
2014-09-09 6:24 ` Baoquan He
2014-09-09 15:53 ` Kees Cook
2014-09-09 19:28 ` Vivek Goyal
2014-09-09 21:13 ` Kees Cook
2014-09-10 7:21 ` Baoquan He
2014-09-10 14:30 ` Vivek Goyal
2014-09-10 14:41 ` Kees Cook
2014-09-10 15:05 ` Vivek Goyal
2014-09-10 15:27 ` Baoquan He
2014-09-10 15:38 ` Vivek Goyal
2014-09-11 9:31 ` Baoquan He
2014-09-11 16:18 ` Kees Cook
2014-09-10 14:53 ` Baoquan He
2014-09-10 15:04 ` Vivek Goyal
2014-09-10 15:13 ` Baoquan He
2014-09-10 6:10 ` Baoquan He
2014-09-10 13:20 ` Vivek Goyal
2014-09-05 14:08 ` [PATCH 2/4] kaslr: check if the random addr is available Baoquan He
2014-09-05 17:16 ` Kees Cook
2014-09-05 22:16 ` Baoquan He
2014-09-09 19:41 ` Vivek Goyal
2014-09-10 13:55 ` Baoquan He
2014-09-05 14:08 ` Baoquan He [this message]
2014-09-05 17:32 ` [PATCH 3/4] kaslr setup_data handling Kees Cook
2014-09-05 22:27 ` Baoquan He
2014-09-09 19:45 ` Vivek Goyal
2014-09-09 19:49 ` H. Peter Anvin
2014-09-09 21:10 ` Kees Cook
2014-09-05 14:08 ` [PATCH 4/4] export the kernel image size KERNEL_IMAGE_SIZE Baoquan He
2014-09-05 17:00 ` Kees Cook
2014-09-09 19:47 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409926097-2101-4-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=ak@linux.intel.com \
--cc=chaowang@redhat.com \
--cc=dyoung@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=whissi@whissi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox