From: Joe Perches <joe@perches.com>
To: Ilja Sidoroff <ilja.sidoroff@iki.fi>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: Remove redundant break/goto statements in hfa384x_usb.c
Date: Mon, 08 Sep 2014 06:47:54 -0700 [thread overview]
Message-ID: <1410184074.12560.6.camel@joe-AO725> (raw)
In-Reply-To: <1410180489-12140-1-git-send-email-ilja.sidoroff@iki.fi>
On Mon, 2014-09-08 at 15:48 +0300, Ilja Sidoroff wrote:
> This patch removes redundant goto or break statements in hfa384x_usb.c as found by checkpatch.pl
[]
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -3528,7 +3528,6 @@ static void hfa384x_usbin_rx(wlandevice_t *wlandev, struct sk_buff *skb)
> netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
> HFA384x_RXSTATUS_MACPORT_GET(
> usbin->rxfrm.desc.status));
> - goto done;
> break;
> }
Better still to change the other use of "goto done" to
"break" and then remove the done label altogether.
next prev parent reply other threads:[~2014-09-08 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 12:48 [PATCH] Staging: wlan-ng: Remove redundant break/goto statements in hfa384x_usb.c Ilja Sidoroff
2014-09-08 13:47 ` Joe Perches [this message]
2014-09-08 14:37 ` [PATCH v2] " Ilja Sidoroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410184074.12560.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=greg@kroah.com \
--cc=ilja.sidoroff@iki.fi \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox