From: George Cherian <george.cherian@ti.com>
To: <cw00.choi@samsung.com>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<myungjoo.ham@samsung.com>, <grant.likely@linaro.org>,
<rongjun.ying@csr.com>, <linux@roeck-us.net>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
George Cherian <george.cherian@ti.com>
Subject: [PATCH 4/5] extcon: gpio: Always use gpio_get_value_cansleep
Date: Tue, 9 Sep 2014 09:44:37 +0530 [thread overview]
Message-ID: <1410236078-11713-5-git-send-email-george.cherian@ti.com> (raw)
In-Reply-To: <1410236078-11713-1-git-send-email-george.cherian@ti.com>
Some gpio's can sleep while reading, so always use gpio_get_value_cansleep
to get data. This fixes warning from gpiolib due to wrong API usage.
Signed-off-by: George Cherian <george.cherian@ti.com>
---
drivers/extcon/extcon-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
index 2bfbd2e..3839749 100644
--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c
@@ -51,7 +51,7 @@ static void gpio_extcon_work(struct work_struct *work)
container_of(to_delayed_work(work), struct gpio_extcon_data,
work);
- state = gpiod_get_value(data->gpiod);
+ state = gpiod_get_value_cansleep(data->gpiod);
extcon_set_state(data->edev, state);
}
--
1.8.3.1
next prev parent reply other threads:[~2014-09-09 4:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 4:14 [PATCH 0/5] Add dt support for extcon gpio driver George Cherian
2014-09-09 4:14 ` [PATCH 1/5] extcon: gpio: Minor cleanups George Cherian
2014-09-22 7:54 ` Chanwoo Choi
2014-09-09 4:14 ` [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's George Cherian
2014-09-22 8:07 ` Chanwoo Choi
2014-09-22 9:51 ` George Cherian
2014-09-22 23:14 ` Chanwoo Choi
2014-09-23 5:14 ` George Cherian
2014-09-09 4:14 ` [PATCH 3/5] extcon: gpio: Add dt support for the driver George Cherian
2014-09-09 4:14 ` George Cherian [this message]
2014-09-09 4:14 ` [PATCH 5/5] extcon: gpio: Add support for using cable names George Cherian
2014-09-16 6:41 ` [PATCH 0/5] Add dt support for extcon gpio driver George Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410236078-11713-5-git-send-email-george.cherian@ti.com \
--to=george.cherian@ti.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rongjun.ying@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).