From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Lennart Poettering <lennart@poettering.net>,
Kay Sievers <kay@vrfy.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wu Zhangjin <falcon@meizu.com>, Takashi Iwai <tiwai@suse.de>,
Arjan van de Ven <arjan@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
hare@suse.com, Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
Benjamin Poirier <bpoirier@suse.de>,
Santosh Rastapur <santosh@chelsio.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Tim Gardner <tim.gardner@canonical.com>,
Pierre Fersing <pierre-fersing@pierref.org>,
Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
Casey Leedom <leedom@chelsio.com>,
Hariprasad S <hariprasad@chelsio.com>,
MPT-FusionLinux.pdl@avagotech.com,
Linux SCSI List <linux-scsi@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM
Date: Mon, 08 Sep 2014 22:38:29 -0700 [thread overview]
Message-ID: <1410241109.2028.22.camel@jarvis.lan> (raw)
In-Reply-To: <20140909011059.GB11706@mtj.dyndns.org>
On Tue, 2014-09-09 at 10:10 +0900, Tejun Heo wrote:
> Hello, Luis.
>
> On Mon, Sep 08, 2014 at 06:04:23PM -0700, Luis R. Rodriguez wrote:
> > > I have no idea how the selection should be. It could be per-insmod or
> > > maybe just a system-wide flag with explicit exceptions marked on
> > > drivers is good enough. I don't know.
> >
> > Its perfectly understandable if we don't know what path to take yet
> > and its also understandable for it to take time to figure out --
> > meanwhile though systemd already has merged a policy of a 30 second
> > timeout for *all drivers* though so we therefore need:
>
> I'm not too convinced this is such a difficult problem to figure out.
> We already have most of logic in place and the only thing missing is
> how to switch it. Wouldn't something like the following work?
>
> * Add a sysctl knob to enable asynchronous device probing on module
> load and enable asynchronous probing globally if the knob is set.
>
> * Identify cases which can't be asynchronous and make them
> synchronous. e.g. keep who's doing request_module() and avoid
> asynchronous probing if current is probing one of those.
What's wrong with just fixing systemd? Arbitrary timeouts in init
scripts for system bring up are plain wrong ... I thought we had this
sorted out ten years ago when we were first having the arguments about
how long to wait for root; I'm surprised it's coming back again.
If we want to sort out some sync/async mechanism for probing devices, as
an agreement between the init systems and the kernel, that's fine, but
its a to-be negotiated enhancement. For the current bug fix, just fix
the component that broke ... which would be systemd.
James
next prev parent reply other threads:[~2014-09-09 5:38 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 6:37 [RFC v2 0/6] driver-core: add asynch probe support Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 1/6] driver-core: generalize freeing driver private member Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 2/6] driver-core: add driver async_probe support Luis R. Rodriguez
2014-09-05 11:24 ` Oleg Nesterov
2014-09-05 17:25 ` Luis R. Rodriguez
2014-09-05 22:10 ` Dmitry Torokhov
2014-10-20 23:43 ` Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 3/6] kthread: warn on kill signal if not OOM Luis R. Rodriguez
2014-09-05 7:19 ` Tejun Heo
2014-09-05 7:47 ` Luis R. Rodriguez
2014-09-05 9:14 ` Mike Galbraith
2014-09-05 14:12 ` Tejun Heo
2014-09-05 16:44 ` Dmitry Torokhov
2014-09-05 17:49 ` Tejun Heo
2014-09-05 18:10 ` Dmitry Torokhov
2014-09-05 22:29 ` Tejun Heo
2014-09-05 22:31 ` Tejun Heo
2014-09-05 22:49 ` Dmitry Torokhov
2014-09-05 22:55 ` Tejun Heo
2014-09-05 23:22 ` Dmitry Torokhov
2014-09-05 23:32 ` Tejun Heo
2014-09-05 22:45 ` Arjan van de Ven
2014-09-05 22:52 ` Dmitry Torokhov
2014-09-05 22:57 ` Tejun Heo
2014-09-05 23:05 ` Arjan van de Ven
2014-09-05 23:18 ` Dmitry Torokhov
2014-09-05 18:12 ` Luis R. Rodriguez
2014-09-05 18:29 ` Dmitry Torokhov
2014-09-05 22:40 ` Tejun Heo
2014-09-09 1:04 ` Luis R. Rodriguez
2014-09-09 1:10 ` Tejun Heo
2014-09-09 1:13 ` Tejun Heo
2014-09-09 1:22 ` Tejun Heo
2014-09-09 1:26 ` Luis R. Rodriguez
2014-09-09 1:29 ` Tejun Heo
2014-09-09 1:38 ` Luis R. Rodriguez
2014-09-09 1:47 ` Tejun Heo
2014-09-09 2:28 ` Luis R. Rodriguez
2014-09-09 2:39 ` Tejun Heo
2014-09-09 2:57 ` Luis R. Rodriguez
2014-09-09 3:03 ` Tejun Heo
2014-09-09 3:19 ` Luis R. Rodriguez
2014-09-09 3:25 ` Tejun Heo
2014-09-09 23:03 ` Tejun Heo
2014-09-12 20:14 ` Luis R. Rodriguez
2014-09-22 16:36 ` Luis R. Rodriguez
2014-09-10 5:13 ` Tom Gundersen
2014-09-09 5:38 ` James Bottomley [this message]
2014-09-09 19:16 ` Luis R. Rodriguez
2014-09-09 19:35 ` James Bottomley
2014-09-09 20:45 ` Luis R. Rodriguez
2014-09-10 6:46 ` [systemd-devel] " Tom Gundersen
2014-09-10 10:07 ` Ceriel Jacobs
2014-09-10 13:31 ` James Bottomley
2014-09-10 21:10 ` Luis R. Rodriguez
2014-09-11 5:42 ` Alexander E. Patrakov
2014-09-11 21:43 ` Tom Gundersen
2014-09-11 22:26 ` Luis R. Rodriguez
2014-09-12 5:48 ` Tom Gundersen
2014-09-12 20:09 ` Luis R. Rodriguez
2014-10-10 21:54 ` Anatol Pomozov
2014-10-10 22:45 ` Tom Gundersen
2014-10-15 19:41 ` Anatol Pomozov
2014-10-15 19:46 ` Alexander E. Patrakov
2014-09-09 21:42 ` Tejun Heo
2014-09-09 22:26 ` James Bottomley
2014-09-09 22:41 ` Tejun Heo
2014-09-09 22:46 ` James Bottomley
2014-09-09 22:52 ` Tejun Heo
2014-09-09 23:01 ` Dmitry Torokhov
2014-09-11 19:59 ` James Bottomley
2014-09-11 20:23 ` Dmitry Torokhov
2014-09-11 20:42 ` Luis R. Rodriguez
2014-09-11 20:53 ` Dmitry Torokhov
2014-09-11 21:08 ` Luis R. Rodriguez
2014-09-22 19:49 ` Pavel Machek
2014-09-22 20:23 ` Dmitry Torokhov
2014-09-30 21:06 ` Pavel Machek
2014-09-30 21:34 ` Dmitry Torokhov
2014-09-09 22:00 ` Jiri Kosina
2014-09-05 10:59 ` Oleg Nesterov
2014-09-05 17:35 ` Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 4/6] cxgb4: use async probe Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 5/6] mptsas: " Luis R. Rodriguez
2014-09-05 7:16 ` Tejun Heo
2014-09-05 7:23 ` Hannes Reinecke
2014-09-05 6:37 ` [RFC v2 6/6] pata_marvell: " Luis R. Rodriguez
2014-09-05 6:59 ` Alexander E. Patrakov
2014-09-05 7:15 ` Tejun Heo
2014-09-05 7:11 ` [RFC v2 0/6] driver-core: add asynch probe support Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410241109.2028.22.camel@jarvis.lan \
--to=james.bottomley@hansenpartnership.com \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=falcon@meizu.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=hariprasad@chelsio.com \
--cc=joseph.salisbury@canonical.com \
--cc=kay@vrfy.org \
--cc=leedom@chelsio.com \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pierre-fersing@pierref.org \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=santosh@chelsio.com \
--cc=sreekanth.reddy@avagotech.com \
--cc=tim.gardner@canonical.com \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox