From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbaIJPfF (ORCPT ); Wed, 10 Sep 2014 11:35:05 -0400 Received: from fallback2.mail.ru ([94.100.179.22]:33354 "EHLO fallback2.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbaIJPfD (ORCPT ); Wed, 10 Sep 2014 11:35:03 -0400 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= To: =?UTF-8?B?VG9iaWFzIEtsYXVzZXI=?= Cc: =?UTF-8?B?SmltIERhdmlz?= , =?UTF-8?B?U3RlcGhlbiBSb3Rod2VsbA==?= , =?UTF-8?B?bGludXgtbmV4dA==?= , =?UTF-8?B?bGludXgta2VybmVs?= , jslaby@suse.cz, linux-serial@vger.kernel.org, =?UTF-8?B?R3JlZyBLcm9haC1IYXJ0bWFu?= Subject: =?UTF-8?B?UmU6IFtQQVRDSF0gdHR5OiBzZXJpYWw6IHNlcmlhbF9tY3RybF9ncGlvOiBG?= =?UTF-8?B?aXggYnVpbGQgZXJyb3IgZm9yICFHUElPTElC?= Mime-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [5.18.98.7] Date: Wed, 10 Sep 2014 18:36:09 +0400 Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= X-Priority: 3 (Normal) Message-ID: <1410359769.646202267@f334.i.mail.ru> X-Cloud-Ids: Content-Type: text/plain; charset=utf-8 X-Mras: Ok X-Spam: undefined In-Reply-To: <20140910141621.GA4636@distanz.ch> References: <20140910135716.GA23074@kroah.com> <20140910141621.GA4636@distanz.ch> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s8AFZBiJ016707 Wed, 10 Sep 2014 16:16:21 +0200 от Tobias Klauser : > On 2014-09-10 at 15:57:16 +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 10, 2014 at 10:06:58AM +0200, Tobias Klauser wrote: > > > If SERIAL_MCTRL_GPIO is selected but GPIOLIB is not, the noop functions > > > from serial_mctrl_gpio.h are pulled in. However, serial_mctrl_gpio.c is > > > still compiled, leading to function redefinition build errors. Since all > > > drivers that include serial_mctrl_gpio.h also depend on > > > SERIAL_MCTRL_GPIO, let it depend on GPIOLIB as well remove the noop > > > functions alltogether. > > > > > > Reported-by: Jim Davis > > > Signed-off-by: Tobias Klauser > > > --- > > > drivers/tty/serial/Kconfig | 1 + > > > drivers/tty/serial/serial_mctrl_gpio.h | 35 ---------------------------------- > > > 2 files changed, 1 insertion(+), 35 deletions(-) > > > > I fixed this yesterday with commit below from Alexander, which does > > things a bit differently than you. Any objections to it? > > This is nicer in terms of being able to compile the driver without > GPIOLIB. However, it wont fix it for the other user of > SERIAL_MCTRL_GPIO, namely SERIAL_ATMEL. And for any future users of > SERIAL_MCTRL_GPIO, we need to make sure to use the same select > directive. To fix it for atmel_serial, I'd suggest the patch below. Atmel serial driver is already protected by ARCH_REQUIRE_GPIOLIB in the architecture configuration. The error is happen only for COMPILE_TEST, but for Atmel driver this option is disabled. --- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I