From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbaILGEz (ORCPT ); Fri, 12 Sep 2014 02:04:55 -0400 Received: from ozlabs.org ([103.22.144.67]:54416 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbaILGEy (ORCPT ); Fri, 12 Sep 2014 02:04:54 -0400 Message-ID: <1410501891.17540.6.camel@concordia> Subject: Re: [PATCH v3 3/3] sched: BUG when stack end location is over written From: Michael Ellerman To: Aaron Tomlin Cc: peterz@infradead.org, dzickus@redhat.com, jcastillo@redhat.com, riel@redhat.com, x86@kernel.org, akpm@linux-foundation.org, minchan@kernel.org, bmr@redhat.com, prarit@redhat.com, oleg@redhat.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org, hannes@cmpxchg.org, mingo@redhat.com, aneesh.kumar@linux.vnet.ibm.com, akpm@google.com, jgh@redhat.com, linuxppc-dev@lists.ozlabs.org, tglx@linutronix.de, pzijlstr@redhat.com Date: Fri, 12 Sep 2014 16:04:51 +1000 In-Reply-To: <1410450088-18236-4-git-send-email-atomlin@redhat.com> References: <1410255749-2956-1-git-send-email-atomlin@redhat.com> <1410450088-18236-1-git-send-email-atomlin@redhat.com> <1410450088-18236-4-git-send-email-atomlin@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote: > Currently in the event of a stack overrun a call to schedule() > does not check for this type of corruption. This corruption is > often silent and can go unnoticed. However once the corrupted > region is examined at a later stage, the outcome is undefined > and often results in a sporadic page fault which cannot be > handled. > > This patch checks for a stack overrun and takes appropriate > action since the damage is already done, there is no point > in continuing. > > Signed-off-by: Aaron Tomlin > --- > kernel/sched/core.c | 3 +++ > lib/Kconfig.debug | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index ec1a286..0b70b73 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -2660,6 +2660,9 @@ static noinline void __schedule_bug(struct task_struct *prev) > */ > static inline void schedule_debug(struct task_struct *prev) > { > +#ifdef CONFIG_SCHED_STACK_END_CHECK > + BUG_ON(unlikely(task_stack_end_corrupted(prev))) > +#endif Spot the bug? Please compile your code in future. ../kernel/sched/core.c: In function ‘schedule_debug’: ../kernel/sched/core.c:2671:2: error: expected ‘;’ before ‘if’ if (unlikely(in_atomic_preempt_off() && prev->state != TASK_DEAD)) ^ ../kernel/sched/core.c: At top level: ../kernel/sched/core.c:2635:22: warning: ‘__schedule_bug’ defined but not used [-Wunused-function] static noinline void __schedule_bug(struct task_struct *prev) ^ make[3]: *** [kernel/sched/core.o] Error 1 make[2]: *** [kernel/sched] Error 2 make[1]: *** [kernel] Error 2 make: *** [sub-make] Error 2 cheers