public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	x86@kernel.org
Subject: Re: Ask help about pre_init_apic_IRQ0()
Date: Fri, 12 Sep 2014 11:19:28 +0300	[thread overview]
Message-ID: <1410509968.7023.33.camel@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1409112354501.4178@nanos>

On Thu, 2014-09-11 at 23:59 +0200, Thomas Gleixner wrote:
[]

> > With patch nothing happened indeed.
> > 
> > 
> > >      x86_intel_mid_timer=apbt_only
> > 
> > [    0.116839] BUG: unable to handle kernel NULL pointer dereference at
> > 0000003a
> > [    0.123803] IP: [<c1071c0e>] setup_irq+0xf/0x4d
> > ...
> > 

w/o patch

[    0.000000] Early APIC setup for system timer0
[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: CPU: 0 PID: 0 at
arch/x86/kernel/apic/apic.c:1393 setup_local_APIC+0x20c/0x2d9()

...and stuck a bit later

> > > or
> > >      x86_intel_mid_timer=lapic_and_apbt
> > 
> > [    0.116858] BUG: unable to handle kernel NULL pointer dereference at
> > 0000003a
> > [    0.123820] IP: [<c1071c0e>] setup_irq+0xf/0x4d
> > ...
> > 

w/o patch

[    0.000000] Early APIC setup for system timer0
[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: CPU: 0 PID: 0 at
arch/x86/kernel/apic/apic.c:1393 setup_local_APIC+0x20c/0x2d9()

...and boots normally


> > > 
> > > on the kernel commandline. But even w/o that patch I doubt that
> > > anything post moorestown even has that apbt trainwreck implemented. If
> > > I'm right then the commandline option will prevent the thing to boot
> > > at all, which is an even better reason to remove that crap
> > > alltogether.
> > 
> > See above.
> 
> That was with the patch applied, right? 

Correct.

> What happens if you undo the
> patch and add the command line options?

See above.

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy


  reply	other threads:[~2014-09-12  8:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  8:44 Ask help about pre_init_apic_IRQ0() Jiang Liu
2014-09-11  8:53 ` Mika Westerberg
2014-09-11  9:08   ` Andy Shevchenko
2014-09-11 23:17     ` David Cohen
2014-09-11 12:58 ` Thomas Gleixner
2014-09-11 14:03   ` Andy Shevchenko
2014-09-11 14:35     ` Thomas Gleixner
2014-09-11 15:15       ` Andy Shevchenko
2014-09-11 21:59         ` Thomas Gleixner
2014-09-12  8:19           ` Andy Shevchenko [this message]
2014-09-12  8:26             ` Thomas Gleixner
2014-09-12  9:25               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410509968.7023.33.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox