From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
Milian Wolff <mail@milianw.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/5] perf tools: Introduce perf_callchain_config()
Date: Sun, 21 Sep 2014 01:18:05 +0900 [thread overview]
Message-ID: <1411229886-24390-5-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1411229886-24390-1-git-send-email-namhyung@kernel.org>
This patch adds support for following config options to ~/.perfconfig file.
[call-graph]
record-mode = dwarf
dump-size = 8192
print-type = fractal
order = callee
threshold = 0.5
print-limit = 128
sort-key = function
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/callchain.c | 33 +++++++++++++++++++++++++++++++++
tools/perf/util/callchain.h | 1 +
tools/perf/util/config.c | 3 +++
3 files changed, 37 insertions(+)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index ba7297230143..ee489a1e3f4c 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -168,6 +168,39 @@ parse_callchain_report_opt(const char *arg)
return 0;
}
+int perf_callchain_config(const char *var, const char *value)
+{
+ if (prefixcmp(var, "call-graph."))
+ return 0;
+ var += 11; /* strlen("call-graph.") == 11 */
+
+ if (!strcmp(var, "record-mode"))
+ return parse_callchain_record_opt(value);
+#ifdef HAVE_DWARF_UNWIND_SUPPORT
+ if (!strcmp(var, "dump-size")) {
+ unsigned long size = 0;
+ int ret;
+
+ ret = get_stack_size(value, &size);
+ callchain_param.dump_size = size;
+
+ return ret;
+ }
+#endif
+ if (!strcmp(var, "print-type"))
+ return parse_callchain_report_opt(value);
+ if (!strcmp(var, "order"))
+ return parse_callchain_report_opt(value);
+ if (!strcmp(var, "threshold"))
+ return parse_callchain_report_opt(value);
+ if (!strcmp(var, "print-limit"))
+ return parse_callchain_report_opt(value);
+ if (!strcmp(var, "sort-key"))
+ return parse_callchain_report_opt(value);
+
+ return 0;
+}
+
static void
rb_insert_callchain(struct rb_root *root, struct callchain_node *chain,
enum chain_mode mode)
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 8adfbf0bab5c..2a1f5a46543a 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -170,6 +170,7 @@ int fill_callchain_info(struct addr_location *al, struct callchain_cursor_node *
extern const char record_callchain_help[];
int parse_callchain_record_opt(const char *arg);
int parse_callchain_report_opt(const char *arg);
+int perf_callchain_config(const char *var, const char *value);
static inline void callchain_cursor_snapshot(struct callchain_cursor *dest,
struct callchain_cursor *src)
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 9970b8b0190b..953512ed72ba 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -396,6 +396,9 @@ int perf_default_config(const char *var, const char *value,
if (!prefixcmp(var, "ui."))
return perf_ui_config(var, value);
+ if (!prefixcmp(var, "call-graph."))
+ return perf_callchain_config(var, value);
+
/* Add other config variables here. */
return 0;
}
--
2.1.0
next prev parent reply other threads:[~2014-09-20 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 16:18 [PATCHSET 0/5] perf tools: Add call-graph config options Namhyung Kim
2014-09-20 16:18 ` [PATCH 1/5] perf hists browser: Fix callchain print bug on TUI Namhyung Kim
2014-09-20 16:18 ` [PATCH 2/5] perf tools: Move callchain config from record_opts to callchain_param Namhyung Kim
2014-09-20 16:18 ` [PATCH 3/5] perf tools: Move some callchain parser functions to callchain.c Namhyung Kim
2014-09-20 16:18 ` Namhyung Kim [this message]
2014-09-22 14:24 ` [PATCH 4/5] perf tools: Introduce perf_callchain_config() Jiri Olsa
2014-09-22 15:19 ` Namhyung Kim
2014-09-22 14:25 ` Jiri Olsa
2014-09-22 14:51 ` Arnaldo Carvalho de Melo
2014-09-22 15:12 ` Namhyung Kim
2014-09-20 16:18 ` [PATCH 5/5] perf tools: Convert {record,top}.call-graph option to call-graph.record-mode Namhyung Kim
2014-09-21 18:25 ` [PATCHSET 0/5] perf tools: Add call-graph config options David Ahern
2014-09-22 14:27 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2014-09-23 1:01 [PATCHSET 0/5] perf tools: Add call-graph config options (v2) Namhyung Kim
2014-09-23 1:01 ` [PATCH 4/5] perf tools: Introduce perf_callchain_config() Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411229886-24390-5-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@milianw.de \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).