From: Chris Rorvick <chris@rorvick.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Chris Rorvick <chris@rorvick.com>,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [RFC RESEND 10/10] usb: Remove __init from early_dbgp_init() prototype
Date: Sun, 28 Sep 2014 23:48:58 -0500 [thread overview]
Message-ID: <1411966138-3053-11-git-send-email-chris@rorvick.com> (raw)
In-Reply-To: <1411966138-3053-1-git-send-email-chris@rorvick.com>
Specifying these attributes in both the prototype and the function
definition is unnecessary and could cause confusion or bugs if they are
inconsistent. As such, __init should only be specified at the function
definition.
Keith Owens suggested this as a janitorial task on LKML several years
ago:
https://lkml.org/lkml/2006/1/14/305
Signed-off-by: Chris Rorvick <chris@rorvick.com>
---
include/linux/usb/ehci-dbgp.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/usb/ehci-dbgp.h b/include/linux/usb/ehci-dbgp.h
index 796c1cd..7344d9e 100644
--- a/include/linux/usb/ehci-dbgp.h
+++ b/include/linux/usb/ehci-dbgp.h
@@ -43,8 +43,7 @@ struct ehci_dbg_port {
};
#ifdef CONFIG_EARLY_PRINTK_DBGP
-#include <linux/init.h>
-extern int __init early_dbgp_init(char *s);
+extern int early_dbgp_init(char *s);
extern struct console early_dbgp_console;
#endif /* CONFIG_EARLY_PRINTK_DBGP */
--
1.9.3
next prev parent reply other threads:[~2014-09-29 4:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 4:48 [RFC RESEND 00/10] Create separate header for ehci-dbgp driver Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 01/10] usb: Create separate header for ehci-dbgp Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 02/10] fusbh200: Make Xen notificaiton consistent with EHCI Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 03/10] fusbh200: Remove superfluous macro definitions Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 04/10] fusbh200: Remove duplicate ehci-dbgp declarations Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 05/10] fusbh200: Use ehci_dbg_port struct Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 06/10] fotg210: Make Xen notificaiton consistent with EHCI Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 07/10] fotg210: Remove superfluous macro definitions Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 08/10] fotg210: Remove duplicate ehci-dbgp declarations Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 09/10] fotg210: Use ehci_dbg_port struct Chris Rorvick
2014-09-29 4:48 ` Chris Rorvick [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-03 3:07 [RFC RESEND 00/10] Create separate header for ehci-dbgp driver Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 10/10] usb: Remove __init from early_dbgp_init() prototype Chris Rorvick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411966138-3053-11-git-send-email-chris@rorvick.com \
--to=chris@rorvick.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox