* [PATCH] block: misplaced rq_complete tracepoint
@ 2014-10-01 12:32 Hannes Reinecke
2014-10-01 13:54 ` Tejun Heo
2014-10-01 14:18 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Reinecke @ 2014-10-01 12:32 UTC (permalink / raw)
To: Jens Axboe; +Cc: Tejun Heo, Christoph Hellwig, linux-kernel, Hannes Reinecke
The rq_complete tracepoint was never issued for empty requests,
causing the resulting blktrace information to never show any
completion for those request.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
block/blk-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 3aff9f5..eb05abf 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2414,11 +2414,11 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
{
int total_bytes;
+ trace_block_rq_complete(req->q, req, nr_bytes);
+
if (!req->bio)
return false;
- trace_block_rq_complete(req->q, req, nr_bytes);
-
/*
* For fs requests, rq is just carrier of independent bio's
* and each partial completion should be handled separately.
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: misplaced rq_complete tracepoint
2014-10-01 12:32 [PATCH] block: misplaced rq_complete tracepoint Hannes Reinecke
@ 2014-10-01 13:54 ` Tejun Heo
2014-10-01 14:18 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2014-10-01 13:54 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: Jens Axboe, Christoph Hellwig, linux-kernel
On Wed, Oct 01, 2014 at 02:32:31PM +0200, Hannes Reinecke wrote:
> The rq_complete tracepoint was never issued for empty requests,
> causing the resulting blktrace information to never show any
> completion for those request.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: misplaced rq_complete tracepoint
2014-10-01 12:32 [PATCH] block: misplaced rq_complete tracepoint Hannes Reinecke
2014-10-01 13:54 ` Tejun Heo
@ 2014-10-01 14:18 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2014-10-01 14:18 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: Tejun Heo, Christoph Hellwig, linux-kernel
On 2014-10-01 06:32, Hannes Reinecke wrote:
> The rq_complete tracepoint was never issued for empty requests,
> causing the resulting blktrace information to never show any
> completion for those request.
Thanks Hannes, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-01 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-01 12:32 [PATCH] block: misplaced rq_complete tracepoint Hannes Reinecke
2014-10-01 13:54 ` Tejun Heo
2014-10-01 14:18 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox