The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: akpm@linux-foundation.org, gregkh@linuxfoundation.org,
	colin.king@canonical.com, luto@amacapital.net,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework
Date: Fri, 03 Oct 2014 10:39:53 -0700	[thread overview]
Message-ID: <1412357993.20838.4.camel@linux-t7sj.site> (raw)
In-Reply-To: <fb7ed86d44adbc7f97f9e42b314e4fce5616959e.1412349412.git.shuahkh@osg.samsung.com>

On Fri, 2014-10-03 at 09:36 -0600, Shuah Khan wrote:
>  	msgque.key = ftok(argv[0], 822155650);
>  	if (msgque.key == -1) {
> -		printf("Can't make key\n");
> -		return -errno;
> +		printf("Can't make key: %d\n", -errno);

So printing a numeric value is quite useless when users actually run
into these errors -- which is why I like err() so much. How about using
strerror() instead?

Thanks,
Davidlohr


  reply	other threads:[~2014-10-03 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 15:36 [PATCH v3 0/5] kselftest framework and test changes to use it Shuah Khan
2014-10-03 15:36 ` [PATCH v3 1/5] selftests: add kselftest framework for uniform test reporting Shuah Khan
2014-10-03 15:36 ` [PATCH v3 2/5] selftests/breakpoints: change test to use ksft framework Shuah Khan
2014-10-03 15:36 ` [PATCH v3 3/5] selftests/ipc: " Shuah Khan
2014-10-03 17:39   ` Davidlohr Bueso [this message]
2014-10-03 19:42     ` Shuah Khan
2014-10-03 20:01       ` Davidlohr Bueso
2014-10-03 15:36 ` [PATCH v3 4/5] selftests/kcmp: " Shuah Khan
2014-10-03 15:36 ` [PATCH v3 5/5] selftests/timers: " Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412357993.20838.4.camel@linux-t7sj.site \
    --to=dave@stgolabs.net \
    --cc=akpm@linux-foundation.org \
    --cc=colin.king@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox