Re: [PATCH V3] kexec: Add IND_FLAGS macro

Benjamin Herrenschmidt
2014-11-12T23:07:30Z

On Wed, 2014-11-12 at 11:29 -0800, Geoff Levand wrote:
> Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
> all the possible kexec IND_ kimage_entry indirection flags. Having this
> macro allows for simplified code in the processing of the kexec
> kimage_entry items. Also, remove the local powerpc definition and use
> the generic one.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> Hi Ben,
>
> Could you give your ack on this, then I'll try to get it
> merged with my other kexec patches.
>
> Thanks.
>
> -Geoff
>
> arch/powerpc/kernel/machine_kexec_64.c | 2 --
> include/linux/kexec.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> index 879b3aa..75652a32 100644
> --- a/arch/powerpc/kernel/machine_kexec_64.c
> +++ b/arch/powerpc/kernel/machine_kexec_64.c
> @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image)
> return 0;
> }
>
> -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
> -
> static void copy_segments(unsigned long ind)
> {
> unsigned long entry;
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 25e039c..b23412c 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -10,6 +10,7 @@
> #define IND_INDIRECTION (1 << IND_INDIRECTION_BIT)
> #define IND_DONE (1 << IND_DONE_BIT)
> #define IND_SOURCE (1 << IND_SOURCE_BIT)
> +#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
>
> #if !defined(__ASSEMBLY__)
>