Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

Jeff Kirsher
2014-10-15T13:05:05Z

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On Wed, 2014-10-15 at 15:59 +0300, Dan Carpenter wrote:
> Or we could fix it but add a multi-line comment with lots of capital
> letters and exclamation marks. I guess we would need to make a
> function
> since this cast is in several places.
>
> void *silence_buggy_casting(u32 pointer)
> {
> /*
> * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
> * FIXME!!! We know this cast is totally buggy. The BCM
> driver
> * doesn't work on 64 bits. But no one knows how to make this
> * work. Oh well. Let's silence the GCC warning.
> * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
> *
> */
> return (void *)(long)pointer;
> }
>
> Something really ugly and gnarly like that would be hard to ignore.

I thought I remember Greg saying something about getting rid of this
driver anyway, but I could be wrong. If Greg decides to keep this
driver around, then I think we should something like your suggestion
above.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]