Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

Jeff Kirsher
2014-10-15T17:45:01Z

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Wed, 2014-10-15 at 09:11 -0700, Joe Perches wrote:
> On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote:
> []
> > I thought I remember Greg saying something about getting rid of this
> > driver anyway, but I could be wrong. If Greg decides to keep this
> > driver around, then I think we should something like your suggestion
> > above.
>
> Or maybe just make the Kconfig depend on X86_32

I like the idea, but won't this exclude other 32 bit systems like MIPS
and I am sure there might be others. I could assume that Beceem WIMAX
was intended for x86 arch's that are 32 bit only, which may be a safe
bet. The only thing we know for sure is that is broken on 64bit.

> ---
> drivers/staging/bcm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig
> index 8acf4b2..fa5a3a4 100644
> --- a/drivers/staging/bcm/Kconfig
> +++ b/drivers/staging/bcm/Kconfig
> @@ -1,6 +1,6 @@
> config BCM_WIMAX
> tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support"
> - depends on USB && NET
> + depends on USB && NET && X86_32
> help
> This is an experimental driver for the Beceem WIMAX chipset used
> by Sprint 4G.
>
>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]