From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
Date: Wed, 15 Oct 2014 10:42:38 -0700 [thread overview]
Message-ID: <1413394958.2412.23.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1413389496.7484.3.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
On Wed, 2014-10-15 at 09:11 -0700, Joe Perches wrote:
> On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote:
> []
> > I thought I remember Greg saying something about getting rid of this
> > driver anyway, but I could be wrong. If Greg decides to keep this
> > driver around, then I think we should something like your suggestion
> > above.
>
> Or maybe just make the Kconfig depend on X86_32
I like the idea, but won't this exclude other 32 bit systems like MIPS
and I am sure there might be others. I could assume that Beceem WIMAX
was intended for x86 arch's that are 32 bit only, which may be a safe
bet. The only thing we know for sure is that is broken on 64bit.
> ---
> drivers/staging/bcm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig
> index 8acf4b2..fa5a3a4 100644
> --- a/drivers/staging/bcm/Kconfig
> +++ b/drivers/staging/bcm/Kconfig
> @@ -1,6 +1,6 @@
> config BCM_WIMAX
> tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support"
> - depends on USB && NET
> + depends on USB && NET && X86_32
> help
> This is an experimental driver for the Beceem WIMAX chipset used
> by Sprint 4G.
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-15 17:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 12:26 [PATCH] bcm/CmHost.c: Fix noisy compile warnings Jeff Kirsher
2014-10-15 12:33 ` Joe Perches
2014-10-15 12:34 ` Dan Carpenter
2014-10-15 12:59 ` Dan Carpenter
2014-10-15 13:03 ` Jeff Kirsher
2014-10-15 16:11 ` Joe Perches
2014-10-15 17:42 ` Jeff Kirsher [this message]
2014-10-15 18:24 ` Fabio Estevam
2014-10-15 18:54 ` Jeff Kirsher
2014-10-15 18:56 ` Joe Perches
2014-10-15 18:56 ` Fabio Estevam
2014-10-15 19:53 ` Dan Carpenter
2014-10-15 20:03 ` Joe Perches
2014-10-16 7:48 ` Dan Carpenter
2014-10-16 7:54 ` Jeff Kirsher
2014-10-15 21:41 ` Matthias Beyer
2014-10-15 22:19 ` Jeff Kirsher
2014-10-15 22:24 ` Matthias Beyer
2014-10-15 22:41 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413394958.2412.23.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox