From: hansechang@gmail.com
To: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org
Cc: konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
david.vrabel@citrix.com, Ian.Campbell@eu.citrix.com,
dgdegra@tycho.nsa.gov, jinsong.liu@alibaba-inc.com,
Chang Huaixin <huaixin.chx@alibaba-inc.com>
Subject: [PATCH] Input: xen-kbdfront - free grant table entry in xenkbd_disconnect_backend
Date: Thu, 16 Oct 2014 09:46:32 +0800 [thread overview]
Message-ID: <1413423992-3005-1-git-send-email-hansechang@gmail.com> (raw)
From: Chang Huaixin <huaixin.chx@alibaba-inc.com>
xenkbd_disconnect_backend doesn't free grant table entry.
This bug affects live migration.
xenkbd_disconnect_backend uses gnttab_end_foreign_access_ref
to handle grant table entry which doesn't really free an entry.
Thus every time we do xenkbd_resume, grant table entry increses
by one. As an grant table entry occupies 8 bytes, an grant table
page has at most 512 entries. Every 512 times we do xenkdb_resume,
grant table pages increses by one.
After around 3500 times of live migration, grant table pages
will increase by 7, causing too many pages to populate and hitting
max_pages limit when assigning pages.Thus assign_pages will fail,
so will live migration.
Signed-off-by: Chang Huaixin <huaixin.chx@alibaba-inc.com>
---
drivers/input/misc/xen-kbdfront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index fbfdc10..e2ecfc6 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -285,7 +285,7 @@ static int xenkbd_connect_backend(struct xenbus_device *dev,
error_evtchan:
xenbus_free_evtchn(dev, evtchn);
error_grant:
- gnttab_end_foreign_access_ref(info->gref, 0);
+ gnttab_end_foreign_access(info->gref, 0, 0UL);
info->gref = -1;
return ret;
}
@@ -296,7 +296,7 @@ static void xenkbd_disconnect_backend(struct xenkbd_info *info)
unbind_from_irqhandler(info->irq, info);
info->irq = -1;
if (info->gref >= 0)
- gnttab_end_foreign_access_ref(info->gref, 0);
+ gnttab_end_foreign_access(info->gref, 0, 0UL);
info->gref = -1;
}
--
1.9.1
next reply other threads:[~2014-10-16 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 1:46 hansechang [this message]
2014-10-16 16:01 ` [Xen-devel] [PATCH] Input: xen-kbdfront - free grant table entry in xenkbd_disconnect_backend David Vrabel
2014-10-16 20:37 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2014-10-11 8:33 hansechang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413423992-3005-1-git-send-email-hansechang@gmail.com \
--to=hansechang@gmail.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=huaixin.chx@alibaba-inc.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox