From: Joe Perches <joe@perches.com>
To: Ionut Alexa <ionut.m.alexa@gmail.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel:module Fix coding style errors and warnings.
Date: Thu, 16 Oct 2014 02:38:53 -0700 [thread overview]
Message-ID: <1413452333.6702.1.camel@perches.com> (raw)
In-Reply-To: <1413452213-27450-1-git-send-email-ionut.m.alexa@gmail.com>
On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote:
> Fixed codin style errors and warnings. Changes printk with
> print_debug/warn. Changed seq_printf to seq_puts.
If you are going to do style cleanups, please make
sure you check your patches with scripts/checkpatch.pl
before sending them.
WARNING: missing space after struct definition
#104: FILE: kernel/module.c:743:
+struct stopref{
WARNING: line over 80 characters
#190: FILE: kernel/module.c:1550:
+ error = sysfs_create_file(&mod->mkobj.kobj, &temp_attr->attr);
total: 0 errors, 2 warnings, 187 lines checked
next prev parent reply other threads:[~2014-10-16 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 9:36 [PATCH] kernel:module Fix coding style errors and warnings Ionut Alexa
2014-10-16 9:38 ` Joe Perches [this message]
2014-10-16 12:57 ` Sudip Mukherjee
2014-10-16 14:46 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2014-10-16 10:35 Ionut Alexa
2014-10-16 23:06 ` Rusty Russell
2014-10-17 8:32 Ionut Alexa
2014-10-19 23:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413452333.6702.1.camel@perches.com \
--to=joe@perches.com \
--cc=ionut.m.alexa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox