From: Joe Perches <joe@perches.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2]
Date: Mon, 20 Oct 2014 16:11:20 -0700 [thread overview]
Message-ID: <1413846680.5407.4.camel@perches.com> (raw)
In-Reply-To: <1413845376-2128-1-git-send-email-prarit@redhat.com>
On Mon, 2014-10-20 at 18:49 -0400, Prarit Bhargava wrote:
> I tested this using both lower and upper case 'c' with the following commit
> text:
[]
I think the patch subject be something like:
"[PATCH] checkpatch: improve commit id/desc style checking in commit message"
The [v2] goes in the subject like this:
"[PATCH V2] checkpatch: ..."
> 11 chars, SHOULD FAIL
> commit 1234567890a
[]
> ERROR: Please use 12 or more chars for the git commit ID
> commit 1234567890a
I'd expect these messages to mention something about the
missing commit description too.
next prev parent reply other threads:[~2014-10-20 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 22:49 [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2] Prarit Bhargava
2014-10-20 23:11 ` Joe Perches [this message]
2014-10-21 0:46 ` Prarit Bhargava
2014-10-21 2:11 ` Joe Perches
2014-10-21 12:03 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413846680.5407.4.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox