From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbaJUCLH (ORCPT ); Mon, 20 Oct 2014 22:11:07 -0400 Received: from smtprelay0021.hostedemail.com ([216.40.44.21]:38549 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752610AbaJUCLF (ORCPT ); Mon, 20 Oct 2014 22:11:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2689:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:6119:6261:10004:10400:10848:11232:11658:11914:12517:12519:12555:12663:12679:12740:13069:13095:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: farm82_43502d40cbe50 X-Filterd-Recvd-Size: 2264 Message-ID: <1413857461.5407.8.camel@perches.com> Subject: Re: [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2] From: Joe Perches To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, Andy Whitcroft Date: Mon, 20 Oct 2014 19:11:01 -0700 In-Reply-To: <5445AD03.6000901@redhat.com> References: <1413845376-2128-1-git-send-email-prarit@redhat.com> <1413846680.5407.4.camel@perches.com> <5445AD03.6000901@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-10-20 at 20:46 -0400, Prarit Bhargava wrote: > > On 10/20/2014 07:11 PM, Joe Perches wrote: > > On Mon, 2014-10-20 at 18:49 -0400, Prarit Bhargava wrote: > >> I tested this using both lower and upper case 'c' with the following commit > >> text: > > [] > > > > I think the patch subject be something like: > > > > "[PATCH] checkpatch: improve commit id/desc style checking in commit message" > > > > The [v2] goes in the subject like this: > > > > "[PATCH V2] checkpatch: ..." > > > >> 11 chars, SHOULD FAIL > >> commit 1234567890a > > > > [] > > > >> ERROR: Please use 12 or more chars for the git commit ID > >> commit 1234567890a > > > > I'd expect these messages to mention something about the > > missing commit description too. > > Hmm ... is that a requirement here? Yes > Currently checkpatch.pl doesn't complain about that. Yes, it does $ ./scripts/checkpatch.pl 0001-part-1.patch ERROR: Please use 12 or more chars for the git commit ID like: 'commit 01234567890ab ("commit description")' #9: commit 1234567, asdf ERROR: Please use 12 or more chars for the git commit ID like: 'commit 01234567890ab ("commit description")' #11: commit 123457 > I can do it but I'd hate to find out that I'm ERRORing on something > that is considered okay to do. It's not, you've changed output.