Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

Matthias Brugger
2014-10-22T13:53:27Z

Hi Joe,

2014-10-22 15:31 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
>
> Hi Matthias,
>
> On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
>> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
>> > +
>> > +if ARCH_MEDIATEK
>> > +
>> > +config MACH_MT6589
>> > + bool "MediaTek MT6589 SoCs support"
>> > + default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8127
>> > + bool "MediaTek MT8127 SoCs support"
>> > + default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8135
>> > + bool "MediaTek MT8135 SoCs support"
>> > + default ARCH_MEDIATEK
>> > +
>> > +endif
>>
>> MACH_MTxxxx are not used nowhere, please remove them.
>
> Yes, they are not used in this series yet.
>
> MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> mt8135 clk driver we are about to send. I don't want to create false
> dependency between these 2 series so I put it here.
> Do you prefer add them when they are first used?

Yes please add them, when they are first used.
Today I had a look on the pinctrl patches you mentioned. It looks to
me as if the config is not needed in the series.

Thanks,
Matthias

[0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505

>
> Joe.C
>
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html