The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Thomas Huth <thuth@linux.vnet.ibm.com>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org
Subject: [PATCH RFC v2 11/16] virtio_blk: use virtio v1.0 endian
Date: Wed, 22 Oct 2014 18:50:55 +0300	[thread overview]
Message-ID: <1413992894-22976-12-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1413992894-22976-1-git-send-email-mst@redhat.com>

From: Cornelia Huck <cornelia.huck@de.ibm.com>

Note that we care only about the fields still in use for virtio v1.0.

Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/block/virtio_blk.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index c6a27d5..327e601 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -113,6 +113,10 @@ static int __virtblk_add_req(struct virtqueue *vq,
 	sg_init_one(&status, &vbr->status, sizeof(vbr->status));
 	sgs[num_out + num_in++] = &status;
 
+	/* we only care about fields valid for virtio-1 */
+	vbr->out_hdr.type = cpu_to_virtio32(vq->vdev, vbr->out_hdr.type);
+	vbr->out_hdr.sector = cpu_to_virtio64(vq->vdev, vbr->out_hdr.sector);
+
 	return virtqueue_add_sgs(vq, sgs, num_out, num_in, vbr, GFP_ATOMIC);
 }
 
-- 
MST


  parent reply	other threads:[~2014-10-22 15:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 15:50 [PATCH RFC v2 00/14] linux: towards virtio-1 guest support Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 01/16] virtio: memory access APIs Michael S. Tsirkin
2014-10-22 17:45   ` Christopher Covington
2014-10-22 18:40     ` Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 02/16] virtio_ring: switch to new " Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 03/16] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 04/16] virtio: add support for 64 bit features Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 05/16] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 06/16] virtio: make endian-ness depend on virtio 1.0 Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 07/16] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 08/16] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 09/16] virtio: set FEATURES_OK Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 10/16] virtio_net: use v1.0 endian Michael S. Tsirkin
2014-10-22 15:50 ` Michael S. Tsirkin [this message]
2014-10-22 15:50 ` [PATCH RFC v2 12/16] KVM: s390: Set virtio-ccw transport revision Michael S. Tsirkin
2014-10-22 15:51 ` [PATCH RFC v2 13/16] KVM: s390: virtio-ccw revision 1 SET_VQ Michael S. Tsirkin
2014-10-22 15:51 ` [PATCH RFC v2 14/16] KVM: s390: enable virtio-ccw revision 1 Michael S. Tsirkin
2014-10-22 15:51 ` [PATCH RFC v2 15/16] virtio_net: fix types for in memory structures Michael S. Tsirkin
2014-10-22 15:51 ` [PATCH RFC v2 16/16] virtio_blk: " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413992894-22976-12-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=thuth@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox