Re: [PATCH v4 0/7] ARM: mediatek: Add support for interrupt polarity

Yingjoe Chen
2014-10-27T07:44:35Z

Hi Matthias,

On Fri, 2014-10-24 at 23:06 +0800, Yingjoe Chen wrote:
> On Fri, 2014-10-24 at 16:59 +0200, Matthias Brugger wrote:
> > Hi Joe,
> >
> > 2014-10-23 17:53 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> > > This series is 4th version of interrupt polarity support for MediaTek SoCs.
> > > This is based on Jiang's hierarchy irqdomain v2 [1] and my mediatek SoC
> > > basic support [2].
> > >
> > > This version addressed comments from previous discussion[3]. I removed
> > > arm,hierarchy-irq-domain property. When GIC is probed by DT, it will
> > > support hierarchy irqdomain. I still keep the first patch because this is
> > > still base on hierarchy irqdomain v2.
> >
> > Is this set based on v3.17-rc1?
> > Is it based on one of Jiangs trees [0]?
> >
> > I tried to use your patch set with v3.18-rc1 using Jiangs tree but the
> > kernel crashed on mt6589 with a null-pointer exception [1]. A test
> > with mt6592 didn't work either.
> >
> > It would be convenient if you rebase your patches to v3.18-rc1.
>
> It is based on Jiang's tree[0], which is based on v3.17-rc1. So yes,
> this series is still on v3.17-rc1.
>
> All I need from Jiang's series are the first 2 patches, I'll bring them
> to v3.18-rc1 to test next week.

I cherry-pick/rebase my series with Jiang's 2 patches to v3.18-rc1,
there are 2 conflicts but they are quite easy to fix so I won't repost
this series now. I tested it on mt8127 with Eddie's uart patch and it
boot to shell successfully.

About crash on mt6589, I made a mistake in mt6589.dtsi. Please help to
test with the following change:

--- a/arch/arm/boot/dts/mt6589.dtsi
+++ b/arch/arm/boot/dts/mt6589.dtsi
@@ -86,7 +86,7 @@
interrupt-controller;
#interrupt-cells = <3>;
interrupt-parent = <&gic>;
- reg = <0 0x10200100 0 0x1c>;
+ reg = <0x10200100 0x1c>;

Joe.C