From: Oliver Neukum <oneukum@suse.de>
To: "SeungGoo, Kim" <nolja.kim@samsung.com>, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH] usbnet: code clean up using checkpatch
Date: Thu, 30 Aug 2012 20:58:42 +0200 [thread overview]
Message-ID: <1414211.Mo8vinPyin@linux-lqwf.site> (raw)
In-Reply-To: <1346325521-27388-1-git-send-email-nolja.kim@samsung.com>
On Thursday 30 August 2012 20:18:41 SeungGoo, Kim wrote:
> @@ -748,8 +752,9 @@ int usbnet_open (struct net_device *net)
> goto done_nopm;
> }
>
> - // put into "known safe" state
> - if (info->reset && (retval = info->reset (dev)) < 0) {
> + /* put into "known safe" state */
> + retval = info->reset(dev);
> + if (info->reset && retval < 0) {
> netif_info(dev, ifup, dev->net,
> "open reset fail (%d) usbnet usb-%s-%s, %s\n",
Dave,
please don't take this patch. It changes code and breaks the driver.
A great big NACK.
Kim,
please do not send coding style patches which change code.
As an exercise think about this piece of code.
Regards
Oliver
next prev parent reply other threads:[~2012-08-30 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 11:18 [PATCH] [PATCH] usbnet: code clean up using checkpatch SeungGoo, Kim
2012-08-30 18:58 ` Oliver Neukum [this message]
2012-08-31 20:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414211.Mo8vinPyin@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nolja.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox