public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	x86@kernel.org
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>, Joerg Roedel <joro@8bytes.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org
Subject: [Patch Part1 v3 01/20] ACPI, irq, x86: Get rid of special handling of GSI for ACPI SCI
Date: Mon, 27 Oct 2014 16:11:52 +0800	[thread overview]
Message-ID: <1414397531-28254-2-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1414397531-28254-1-git-send-email-jiang.liu@linux.intel.com>

The IOAPIC has logic to track IOAPIC pin status, so there's no need for
special treatment for GSI used by ACPI SCI in function mp_register_gsi()
and mp_unregister_gsi().

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 arch/x86/kernel/acpi/boot.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index f27b33194e06..47334a918d16 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -408,10 +408,6 @@ static int mp_register_gsi(struct device *dev, u32 gsi, int trigger,
 	if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
 		return gsi;
 
-	/* Don't set up the ACPI SCI because it's already set up */
-	if (acpi_gbl_FADT.sci_interrupt == gsi)
-		return mp_map_gsi_to_irq(gsi, IOAPIC_MAP_ALLOC);
-
 	trigger = trigger == ACPI_EDGE_SENSITIVE ? 0 : 1;
 	polarity = polarity == ACPI_ACTIVE_HIGH ? 0 : 1;
 	node = dev ? dev_to_node(dev) : NUMA_NO_NODE;
@@ -424,7 +420,8 @@ static int mp_register_gsi(struct device *dev, u32 gsi, int trigger,
 	if (irq < 0)
 		return irq;
 
-	if (enable_update_mptable)
+	/* Don't set up the ACPI SCI because it's already set up */
+	if (enable_update_mptable && acpi_gbl_FADT.sci_interrupt != gsi)
 		mp_config_acpi_gsi(dev, gsi, trigger, polarity);
 
 	return irq;
@@ -437,9 +434,6 @@ static void mp_unregister_gsi(u32 gsi)
 	if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
 		return;
 
-	if (acpi_gbl_FADT.sci_interrupt == gsi)
-		return;
-
 	irq = mp_map_gsi_to_irq(gsi, 0);
 	if (irq > 0)
 		mp_unmap_irq(irq);
-- 
1.7.10.4


  reply	other threads:[~2014-10-27  8:09 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27  8:11 [Patch Part1 v3 00/20] Prepare for enabling hierarchy irqdomain on x86 Jiang Liu
2014-10-27  8:11 ` Jiang Liu [this message]
2014-11-05 16:34   ` [tip:x86/apic] ACPI, irq, x86: Get rid of special handling of GSI for ACPI SCI tip-bot for Jiang Liu
2014-11-05 17:12   ` tip-bot for Jiang Liu
2014-12-19 14:05   ` [tip:x86/apic] x86, irq, acpi: " tip-bot for Jiang Liu
2014-10-27  8:11 ` [Patch Part1 v3 02/20] x86, irq, ACPI: Fix building warning of unused code Jiang Liu
2014-11-05 16:34   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:13   ` tip-bot for Jiang Liu
2014-12-19 14:01   ` tip-bot for Jiang Liu
2014-10-27  8:11 ` [Patch Part1 v3 03/20] x86, irq: Kill fourth parameter of IO_APIC_get_PCI_irq_vector() Jiang Liu
2014-11-05 16:35   ` [tip:x86/apic] x86, irq: Kill useless parameter 'irq_attr' " tip-bot for Jiang Liu
2014-11-05 17:13   ` tip-bot for Jiang Liu
2014-12-19 14:06   ` tip-bot for Jiang Liu
2014-10-27  8:11 ` [Patch Part1 v3 04/20] x86, irq: Convert irq_2_pin list to generic list Jiang Liu
2014-11-05 16:35   ` [tip:x86/apic] " tip-bot for Yinghai Lu
2014-11-05 17:13   ` tip-bot for Yinghai Lu
2014-12-19 14:06   ` tip-bot for Yinghai Lu
2014-10-27  8:11 ` [Patch Part1 v3 05/20] x86, irq: Refine hw_irq.h to prepare for irqdomain support Jiang Liu
2014-11-05 16:35   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:13   ` tip-bot for Jiang Liu
2014-12-19 14:06   ` tip-bot for Jiang Liu
2014-10-27  8:11 ` [Patch Part1 v3 06/20] x86, irq: Rename local APIC related functions in io_apic.c as apic_xxx() Jiang Liu
2014-11-05 16:36   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:14   ` tip-bot for Jiang Liu
2014-12-19 14:07   ` tip-bot for Jiang Liu
2014-10-27  8:11 ` [Patch Part1 v3 07/20] x86, irq: Protect __clear_irq_vector() with vector_lock Jiang Liu
2014-11-05 16:36   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:14   ` tip-bot for Jiang Liu
2014-12-19 14:07   ` tip-bot for Jiang Liu
2014-10-27  8:11 ` [Patch Part1 v3 08/20] x86, irq: Introduce helpers to access struct irq_cfg Jiang Liu
2014-11-05 16:36   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:14   ` tip-bot for Jiang Liu
2014-12-19 14:07   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 09/20] x86, irq: Move local APIC related code from io_apic.c into vector.c Jiang Liu
2014-11-05 16:37   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:14   ` tip-bot for Jiang Liu
2014-12-19 14:08   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 10/20] x86, irq: Replace printk(KERN_LVL) with pr_lvl() utilities Jiang Liu
2014-11-05 16:37   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 16:47     ` Joe Perches
2014-11-05 17:15   ` tip-bot for Jiang Liu
2014-12-19 14:08   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 11/20] x86, irq: Move PCI MSI related code from io_apic.c into msi.c Jiang Liu
2014-11-05 16:38   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:15   ` tip-bot for Jiang Liu
2014-12-19 14:08   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 12/20] x86, irq: Move HT IRQ related code from io_apic.c into htirq.c Jiang Liu
2014-11-05 16:38   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:16   ` tip-bot for Jiang Liu
2014-12-19 14:09   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 13/20] x86, irq: Move IOAPIC related declarations from hw_irq.h into io_apic.h Jiang Liu
2014-11-05 16:38   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:16   ` tip-bot for Jiang Liu
2014-12-19 14:09   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 14/20] x86, irq: Move IRQ initialization routines from io_apic.c into vector.c Jiang Liu
2014-11-05 16:38   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:16   ` tip-bot for Jiang Liu
2014-12-19 14:09   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 15/20] x86, irq: Make MSI and HT_IRQ indepenent of X86_IO_APIC Jiang Liu
2014-11-05 16:39   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:16   ` tip-bot for Jiang Liu
2014-12-19 14:10   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 16/20] x86, irq: Use helpers to access irq_cfg data structure associated with IRQ Jiang Liu
2014-11-05 16:39   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:17   ` tip-bot for Jiang Liu
2014-12-19 14:10   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 17/20] x86: irq_remapping: " Jiang Liu
2014-11-05 16:39   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:17   ` tip-bot for Jiang Liu
2014-12-19 14:10   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 18/20] iommu/vt-d: " Jiang Liu
2014-11-05 16:39   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:17   ` tip-bot for Jiang Liu
2014-12-19 14:11   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 19/20] iommu/amd: " Jiang Liu
2014-11-05 16:40   ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-05 17:17   ` tip-bot for Jiang Liu
2014-12-19 14:11   ` tip-bot for Jiang Liu
2014-10-27  8:12 ` [Patch Part1 v3 20/20] x86, irq: Fix link error of undefined reference to send_cleanup_vector Jiang Liu
2014-11-05 16:34   ` [tip:x86/apic] x86, irq: Provide empty send_cleanup_vector() stub for UP builds tip-bot for Jiang Liu
2014-11-05 17:12   ` tip-bot for Jiang Liu
2014-12-19 14:00   ` tip-bot for Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414397531-28254-2-git-send-email-jiang.liu@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox