Re: [PATCH 2/2] x86, mce: support memory error recovery for both UCNA and Deferred error in machine_check_poll

Borislav Petkov
2014-11-04T11:38:39Z

On Wed, Oct 29, 2014 at 10:16:04AM +0800, Chen Yucong wrote:
> + /*
> + * mce_severity is specific to machine check exception, and it will
> + * check MCIP/EIPV/RIPV bits. In order to get pass the check, we need
> + * to set MCIP and RIPV.
> + */

No, no more hacks please! Less hacks and cleaner code instead.

You need to integrate it properly in the current solution, or, if the
current solution doesn't provide a proper way of integrating UCNA
errors, then you need to extend it and improve it to do so.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--