From: Joe Perches <joe@perches.com>
To: Steven Honeyman <stevenhoneyman@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jiri Kosina <trivial@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, cpu: trivial printk formatting fixes
Date: Sat, 01 Nov 2014 10:17:53 -0700 [thread overview]
Message-ID: <1414862273.31550.4.camel@perches.com> (raw)
In-Reply-To: <1414856696-8094-1-git-send-email-stevenhoneyman@gmail.com>
On Sat, 2014-11-01 at 15:44 +0000, Steven Honeyman wrote:
> A 2 line printk makes dmesg output messy, because the second line does not get a timestamp.
> For example:
[]
> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
[]
> @@ -487,10 +487,8 @@ static void init_intel(struct cpuinfo_x86 *c)
>
> rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
> if ((epb & 0xF) == ENERGY_PERF_BIAS_PERFORMANCE) {
> - printk_once(KERN_WARNING "ENERGY_PERF_BIAS:"
> - " Set to 'normal', was 'performance'\n"
> - "ENERGY_PERF_BIAS: View and update with"
> - " x86_energy_perf_policy(8)\n");
> + pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
> + pr_info_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
This changes the logging level.
You should either mention why in the changelog
or use pr_warn_once
next prev parent reply other threads:[~2014-11-01 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 15:44 [PATCH] x86, cpu: trivial printk formatting fixes Steven Honeyman
2014-11-01 17:17 ` Joe Perches [this message]
2014-11-01 17:19 ` Borislav Petkov
2014-11-01 17:38 ` Steven Honeyman
2014-11-01 17:51 ` Borislav Petkov
2014-11-02 4:03 ` Steven Honeyman
2014-11-02 11:13 ` Borislav Petkov
2014-11-01 17:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414862273.31550.4.camel@perches.com \
--to=joe@perches.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stevenhoneyman@gmail.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox