From: Joe Perches <joe@perches.com>
To: Steven Honeyman <stevenhoneyman@gmail.com>,
Len Brown <len.brown@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jiri Kosina <trivial@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, cpu: trivial printk formatting fixes
Date: Sat, 01 Nov 2014 10:57:34 -0700 [thread overview]
Message-ID: <1414864654.31550.6.camel@perches.com> (raw)
In-Reply-To: <CABz95_BFew81JGAf=oP=6m9yPMi1_JmvfjKgX2CxFmha52A54w@mail.gmail.com>
(Adding Len Brown, original post: https://lkml.org/lkml/2014/11/1/67)
On Sat, 2014-11-01 at 17:38 +0000, Steven Honeyman wrote:
> On 1 November 2014 17:17, Joe Perches <joe@perches.com> wrote:
> > This changes the logging level.
> >
> > You should either mention why in the changelog
> > or use pr_warn_once
>
> OK, I will resubmit with a new description if needed.
> Would you agree that info is a more suitable log level than warn for
> this message? Even notice seemed too much, as it isn't a 'significant
> condition'
This is only emitted when the bios didn't do the "right thing".
See commit abe48b108247e9b90
So it seems more like the origial message isn't descriptive
enough than KERN_WARN is not the correct level.
prev parent reply other threads:[~2014-11-01 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 15:44 [PATCH] x86, cpu: trivial printk formatting fixes Steven Honeyman
2014-11-01 17:17 ` Joe Perches
2014-11-01 17:19 ` Borislav Petkov
2014-11-01 17:38 ` Steven Honeyman
2014-11-01 17:51 ` Borislav Petkov
2014-11-02 4:03 ` Steven Honeyman
2014-11-02 11:13 ` Borislav Petkov
2014-11-01 17:57 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414864654.31550.6.camel@perches.com \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stevenhoneyman@gmail.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox