From: Chris Rorvick <chris@rorvick.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Chris Rorvick <chris@rorvick.com>,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [RFC RESEND 07/10] fotg210: Remove superfluous macro definitions
Date: Sun, 2 Nov 2014 21:07:54 -0600 [thread overview]
Message-ID: <1414984077-9750-8-git-send-email-chris@rorvick.com> (raw)
In-Reply-To: <1414984077-9750-1-git-send-email-chris@rorvick.com>
The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition
in the <linux/usb/ehci_def.h> header. Embedded in this definition are
a number of macros which came along for the ride. These macros are not
used in the fotg210 driver and will conflict those in the new
<linux/usb/ehci-dbgp.h> header.
Signed-off-by: Chris Rorvick <chris@rorvick.com>
---
drivers/usb/host/fotg210.h | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host/fotg210.h
index 98c9670..c2e5134 100644
--- a/drivers/usb/host/fotg210.h
+++ b/drivers/usb/host/fotg210.h
@@ -298,24 +298,10 @@ struct fotg210_regs {
*/
struct fotg210_dbg_port {
u32 control;
-#define DBGP_OWNER (1<<30)
-#define DBGP_ENABLED (1<<28)
-#define DBGP_DONE (1<<16)
-#define DBGP_INUSE (1<<10)
-#define DBGP_ERRCODE(x) (((x)>>7)&0x07)
-# define DBGP_ERR_BAD 1
-# define DBGP_ERR_SIGNAL 2
-#define DBGP_ERROR (1<<6)
-#define DBGP_GO (1<<5)
-#define DBGP_OUT (1<<4)
-#define DBGP_LEN(x) (((x)>>0)&0x0f)
u32 pids;
-#define DBGP_PID_GET(x) (((x)>>16)&0xff)
-#define DBGP_PID_SET(data, tok) (((data)<<8)|(tok))
u32 data03;
u32 data47;
u32 address;
-#define DBGP_EPADDR(dev, ep) (((dev)<<8)|(ep))
};
#ifdef CONFIG_EARLY_PRINTK_DBGP
--
1.9.3
next prev parent reply other threads:[~2014-11-03 3:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 3:07 [RFC RESEND 00/10] Create separate header for ehci-dbgp driver Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 01/10] usb: Create separate header for ehci-dbgp Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 02/10] fusbh200: Make Xen notificaiton consistent with EHCI Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 03/10] fusbh200: Remove superfluous macro definitions Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 04/10] fusbh200: Remove duplicate ehci-dbgp declarations Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 05/10] fusbh200: Use ehci_dbg_port struct Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 06/10] fotg210: Make Xen notificaiton consistent with EHCI Chris Rorvick
2014-11-03 3:07 ` Chris Rorvick [this message]
2014-11-03 3:07 ` [RFC RESEND 08/10] fotg210: Remove duplicate ehci-dbgp declarations Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 09/10] fotg210: Use ehci_dbg_port struct Chris Rorvick
2014-11-03 3:07 ` [RFC RESEND 10/10] usb: Remove __init from early_dbgp_init() prototype Chris Rorvick
2014-11-03 23:09 ` [RFC RESEND 00/10] Create separate header for ehci-dbgp driver Greg Kroah-Hartman
2014-11-05 1:44 ` Chris Rorvick
2014-11-04 8:46 ` Daniele Forsi
-- strict thread matches above, loose matches on Subject: below --
2014-09-29 4:48 Chris Rorvick
2014-09-29 4:48 ` [RFC RESEND 07/10] fotg210: Remove superfluous macro definitions Chris Rorvick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414984077-9750-8-git-send-email-chris@rorvick.com \
--to=chris@rorvick.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox