Re: [PATCH v4 2/8] ARM: mediatek: add dts for 8127 Moose board

[Yingjoe Chen <yingjoe.chen@mediatek.com>]

On Mon, 2014-11-03 at 18:55 +0100, Matthias Brugger wrote:
> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> > From: "Joe.C" <yingjoe.chen@mediatek.com>
> >
> > Moose is a tablet evalutation board based on MT8127 SoC.
> >
> > Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> > ---
> >  arch/arm/boot/dts/mt8127-moose.dts | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/mt8127-moose.dts
> >
> > diff --git a/arch/arm/boot/dts/mt8127-moose.dts b/arch/arm/boot/dts/mt8127-moose.dts
> > new file mode 100644
> > index 0000000..602e2f0
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mt8127-moose.dts
> > @@ -0,0 +1,24 @@
> > +/*
> > + * Copyright (c) 2014 MediaTek Inc.
> > + * Author: Joe.C <yingjoe.chen@mediatek.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8127.dtsi"
> > +
> > +/ {
> > +       model = "mediatek,mt8127-moose", "mediatek,mt8127";
> 
> The model should be a string that identifies the board, e.g. "Moose".
> Please add the compatible property.

Thanks for catching this. I just note we have warning on this line.
Will fix in next version.

Joe.C