From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbaKDHuV (ORCPT ); Tue, 4 Nov 2014 02:50:21 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:32049 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbaKDHuP (ORCPT ); Tue, 4 Nov 2014 02:50:15 -0500 X-AuditID: cbfec7f4-b7f6c6d00000120b-08-545885333678 Message-id: <1415087409.2389.2.camel@AMDC1943> Subject: Re: [PATCH 7/7] mfd: ab8500: Decrement the power supply's device reference counter From: Krzysztof Kozlowski To: Lee Jones Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Linus Walleij , Samuel Ortiz , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Konrad Rzeszutek Wilk , "Rafael J. Wysocki" , Lv Zheng , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Anton Vorontsov , Pavel Machek , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Date: Tue, 04 Nov 2014 08:50:09 +0100 In-reply-to: <20141103180059.GW12011@x1> References: <1413290117-13082-1-git-send-email-k.kozlowski@samsung.com> <1413290117-13082-8-git-send-email-k.kozlowski@samsung.com> <20141103175945.GV12011@x1> <20141103180059.GW12011@x1> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02RW0iTYRzGefft+/Y5GryuZS9CietgCs6GQa8i0lV8JIHVLtSSWrqc4KZs zlKi1JJKMZ1m5Iwx8nxK/ZY1D1gND0tNpKVGni7MNI9MHWrFyLUb7378+T3Pc/GnCWE715dO VqcrNGp5ipjic4dcA/bg0LwY2emOQRJ/bA/EbS9aSFyVq8QlP9YJrK8vJfDztsO4pnIe4M+5 Kzw86+wD+NnfWg5m58ZJbO98SeHNwl6AHdWtJG7unebhLx9MHDw92EfhubpVHh4qIPFQVzo2 s2UE3mmdI8/5MMVFG4DpMEzzGBOrY8x1QUxl9y8OwzY8oZip8W6KWRsZ4THGT5cYc9V9xjH/ ncus94xRzNM3DYCpa9zmMZvsUcb2cIuMhnH8iERFSnKGQhMSeYOvdOQvctK2+XcmJnq52cBE 5wMvGsEzaHhqjedhHzQ600K5WQirAVqdlHl4E6An2RFuFkAJ+lpu5Lj5IIxHbL0NuJmCochc W7WXpWkRPI5GVs7mAz5NQJZCNWMVpNvhwhNo11FAuNkLnkKsqxO4JSF8D1CPc+f/MAEDUInx FeEuQvAYyik679n1RjulM1yP4ofMTatEMYCGfQnDPs2wTzMBogEcUugS0rQ3k1RSiVau0urU SZKEVBULPK/esoDK/nArgDQQHxAoA2JkQlKeoc1UWQGiCbFI0Ji1dxIkyjOzFJrU6xpdikJr BRzayzcbXF1WWbbWjwzcvRymKabQ5GgUfGCzx4XHhqh9Y17/9E8Lq/BTWNoylt/5c53Bljxl YVmgvYCWbOj1jX/0j63SmYSl6AJovyI1Ny1eG66OflTuyvl9++LYrYXZBVOmWPStSxZrvLBL RL2914xyevptwd42V3+kxlkkik9eOinmapVyaRCh0cr/AVqbJyLIAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pon, 2014-11-03 at 18:00 +0000, Lee Jones wrote: > On Mon, 03 Nov 2014, Lee Jones wrote: > > > On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote: > > > > > Use power_supply_put() to decrement the power supply's device reference > > > counter. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > drivers/mfd/ab8500-sysctrl.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Applied, thanks. > > Whoops, to hasty there -- unapplied. > > What's going on with this set? The set should be pulled at once (everything depends on 1st patch). It is still waiting for reviews. I'll resend soon. Best regards, Krzysztof > > > > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c > > > index 93b2d2c32ca3..d05a5719cfc4 100644 > > > --- a/drivers/mfd/ab8500-sysctrl.c > > > +++ b/drivers/mfd/ab8500-sysctrl.c > > > @@ -51,6 +51,7 @@ static void ab8500_power_off(void) > > > > > > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, > > > &val); > > > + power_supply_put(psy); > > > > > > if (!ret && val.intval) { > > > charger_present = true; > > > @@ -73,6 +74,7 @@ static void ab8500_power_off(void) > > > pss[i]); > > > machine_restart("charging"); > > > } > > > + power_supply_put(psy); > > > } > > > > > > shutdown: > > >