From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbaKDKpG (ORCPT ); Tue, 4 Nov 2014 05:45:06 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:39570 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbaKDKpD (ORCPT ); Tue, 4 Nov 2014 05:45:03 -0500 X-AuditID: cbfec7f5-b7f956d000005ed7-44-5458ae2cf9f4 Message-id: <1415097899.7941.10.camel@AMDC1943> Subject: Re: [PATCH v4 00/14] Add max77802 regulator operating mode support From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: Mark Brown , Kukjin Kim , Chanwoo Choi , Olof Johansson , Chris Zhong , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Tue, 04 Nov 2014 11:44:59 +0100 In-reply-to: <1415025649-8119-1-git-send-email-javier.martinez@collabora.co.uk> References: <1415025649-8119-1-git-send-email-javier.martinez@collabora.co.uk> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xy7o66yJCDOYvN7GY+vAJm8X1L89Z LeYfOcdqcfR3gcWav0oWvQuusllc3jWHzWLG+X1MFqeuf2azmP9gB7MDl8ff59dZPHbOusvu sWlVJ5vHlRNNrB5/Z+1n8ejbsorR4/MmuQD2KC6blNSczLLUIn27BK6MX/fqCx7IVaxa/4+l gfGJRBcjJ4eEgInE8Tt7WSFsMYkL99azdTFycQgJLGWUuLZtFQuE85lRYsL6x+wgVbwC+hL3 Dz8Csjk4hAW8JX6+0wYJswkYS2xevoQNxBYRsJO4sfohM0gvs8AxJomZq9axgCRYBFQlDq06 xwhicwr4S5z4so8JxBYS8JNYv2U3WA2zgLrEpHmLmEHmSwgoSzT2u0GsFZT4MfkeVIm8xOY1 b5knMArMQtIxC0nZLCRlCxiZVzGKppYmFxQnpeca6RUn5haX5qXrJefnbmKERMTXHYxLj1kd YhTgYFTi4V0RHxEixJpYVlyZe4hRgoNZSYR3dRVQiDclsbIqtSg/vqg0J7X4ECMTB6dUA+Ph p3fZDL2Ep3JZcO5wcapVX5j5jN0tmVlrq2Xd150HRZ4uiXW6pG9d59f0UD+APeV6RHja4jVR EZ+kisTEZr42DD66WHqa7NkvZVnzUtq2RAarGf99nNTOvziboXnjXwOWzGPuHy7I1piqMKWW nVnxdJl52Gn5SI4p719vqN8ht6Qo2qpRUomlOCPRUIu5qDgRAHVMx7lmAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pon, 2014-11-03 at 15:40 +0100, Javier Martinez Canillas wrote: > Hello Mark, > > This is the fourth version of the series that adds operating modes > support for the regulators in the max77802 PMIC. This version uses > the standard suspend states bindings and the opmodes are parsed by > the regulator core while drivers only define a translation function > to map between hardware specific to standard modes as you suggested. > > The series adds a "regulator-initial-mode" property to configure at > startup the operating mode for the regulators that support changing > its mode during normal operation and a "regulator-mode" property for > the regulators that supports changing its operating mode when the > system enters in a suspend state. These properties were originally > part of Chanwoo Choi's regulator suspend state series [0] but were > removed since there wasn't a way to define the operating modes in a > generic way. > > In this series, the generic regulator DT binding doc explains that each > device has to document what their valid operating modes are. Drivers > must provide a translation function so the core can map the modes. > > Since parsing the modes in the core is a very different approach, most > of the patches are new but those that remains have a changelog. > > This series depend on [0] and also v2 of patch: > "ARM: EXYNOS: Call regulator core suspend prepare and finish functions" [1]. > > Javier Martinez Canillas (14): > regulator: Document binding for initial and suspend modes > regulator: Add function to map modes to struct regulator_desc > regulator: of: Add regulator desc param to > of_get_regulator_init_data() > regulator: of: Pass the regulator description in the match table > regulator: max1586: zero-initialize regulator match table array > regulator: max77686: zero-initialize regulator match table > regulator: max77802: zero-initialize regulator match table > regulator: max8660: zero-initialize regulator match table array > regulator: s2mpa01: zero-initialize regulator match table array > regulator: of: Add support for parsing initial and suspend modes > regulator: max77802: Document binding for regulator operating modes > regulator: max77802: Use unsigned int for modes in max77802_map_mode() > regulator: max77802: Set regulator modes translation callback > ARM: dts: Configure regulators for suspend on exynos Peach boards > > Patch #1 extends the regulator DT binding to document the initial and > suspend modes properties. > > Patch #2 adds a function pointer to the static regulator description > so drivers can define a callback that does the modes translation. > > Patch #3 does some refactoring to pass the regulator descriptor to the > function extracting the regulator initial data from DT. > > Patch #4 adds a pointer to the regulator descriptor in the match table > so users extracting the init_data from of_regulator_match can also map > the modes. > > Patch #5-#9 are fixes to be sure that all callers are passing an > initialised match table. > > Patch #10 modifies the function that extracts the regulator data from > DT to parse the initial and suspend modes. > > Patch #11 extends the max77802 DT binding to document the valid opmodes > for the regulators on this device. > > Patch #12 change the signature of the function doing the modes mapping > for the max77802 regulators mode. > > Patch #13 set the function handler for the max77802 modes translation. > > Patch #14 configure the regulators for the Peach Pit and Pi Chromebooks. > > Best regards, > Javier > > [0]: https://lkml.org/lkml/2014/10/10/161 > [1]: http://www.spinics.net/lists/arm-kernel/msg369923.html Where's a diff stat? It is helpful to see what files were touched and I believe it is created by default with format-patch. Bet regards, Krzysztof