Re: [PATCH v4 10/14] regulator: of: Add support for parsing initial and suspend modes

Javier Martinez Canillas
2014-11-04T11:07:19Z

Hello Krzysztof,

On 11/04/2014 11:41 AM, Krzysztof Kozlowski wrote:
>> + if (!of_property_read_u32(np, "regulator-initial-mode", &pval)) {
>> + if (desc && desc->map_modes)
>> + constraints->initial_mode = desc->map_modes(pval);
>> + else
>> + pr_warn("%s: failed to parse regulator-initial-mode\n",
>> + np->name);
>> + }
>> +
>
> Here's a hidden assumption that if driver does not provide map_modes
> then any "regulator-initial-mode" property is not valid. Shouldn't this
> be mentioned somewhere? Maybe in description of map_modes callback?
>

Well it can't be valid if the regulator core does not know how to map the
value in the property to one of the standard modes. The binding explains
that each PMIC has to define its hardware modes, I can also add a note
in the .map_modes. I guess no one will say no to more documentation :-)

Best regards,
Javier