From: Joe Perches <joe@perches.com>
To: Jan Kara <jack@suse.cz>
Cc: Anton Blanchard <anton@samba.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: quota: Use quota_err and use %pf to reduce code size
Date: Tue, 04 Nov 2014 06:09:27 -0800 [thread overview]
Message-ID: <1415110167.24560.4.camel@perches.com> (raw)
In-Reply-To: <20141104111525.GE2953@quack.suse.cz>
On Tue, 2014-11-04 at 12:15 +0100, Jan Kara wrote:
> On Mon 03-11-14 20:04:41, Joe Perches wrote:
> > Use more standard logging style and remove __func__ passed
> > to quota_err.
> >
> > Remove the quota_error macro, rename __quota_error to quota_err.
> > Add %pf and __builtin_return_address(0) instead of __func__
[]
> Changing
> __func__ to __builtin_return_address(0) is mostly pointless. OK, saves you
> 600 bytes but quota isn't really aimed at embedded systems and it reduces
> usefullness of the message because of inlining.
That doesn't make any sense to me.
__quota_error or quota_err is specifically not inlined.
It's EXPORT_SYMBOL.
> Adding '\n' at the end of
> messages instead of doing it automatically in quota_error() is also IMO
> pointless churn (there are other error reporting functions in kernel which
> do this so it's not like we have a consensus on this).
Fewer and fewer
prev parent reply other threads:[~2014-11-04 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 4:04 [PATCH] fs: quota: Use quota_err and use %pf to reduce code size Joe Perches
2014-11-04 11:15 ` Jan Kara
2014-11-04 14:09 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415110167.24560.4.camel@perches.com \
--to=joe@perches.com \
--cc=anton@samba.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox