Re: [PATCH -next 20/27] tty: Refactor __tty_hangup to enable lockdep annotation

Peter Hurley
2014-10-27T22:13:53Z

On 10/16/2014 04:25 PM, Peter Hurley wrote:
> Refactor __tty_hangup() into:
> 1. __tty_hangup_common(), the portion requiring the tty lock
> 2. __tty_hangup(), which performs the pre- and post-lock processing
> (TIOCCONS redirect undo) and calls through a function ptr parameter
> to lock/hangup/unlock
> 3. __tty_hangup_standard(), which performs the lock/hangup/unlock
>
> Allows an alternate function to lock/hangup/unlock with the
> nested tty lock.

I just discovered that lockdep provides an interface for setting the
lock subclass after lock initialization. Which means that the lock
subclass can be changed just for slave ptys, which allows lock nesting
without specifying the subclass at lock time. Which eliminates the need
for this patch and the follow-on.

I'll respin this series.

Regards,
Peter Hurley