linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Jiri Slaby <jslaby@suse.cz>,
	Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH 0/4] fix serial console suspend on PNP
Date: Wed,  5 Nov 2014 13:40:50 -0500	[thread overview]
Message-ID: <1415212854-16944-1-git-send-email-peter@hurleysoftware.com> (raw)

Hi Greg,

The kernel command line parameter, no_console_suspend, enables the serial
console to continue to output kernel message during system suspend/resume.

However, the PNP bus will disable and power-down pnp devices on system
suspend, which defeats the purpose of no_console_suspend; namely to continue
to output messages in case those are the last messages before crashing.

The first patch is a cleanup of the baroque logic of uart_suspend_port().
The second patch overrides the PNP bus disabling the console device if
no_console_suspend is set. This patch uses existing PNP bus logic but
perhaps in a way not originally intended.
The third patch requires Rafael's ack, as it adds a capability to allow
the device to override the power-down function.
The fourth patch actually performs the power-down override enabled by
patch 3.

With these patches, the PNP0501 device (16550A uart) will continue to
output messages while system suspend finishes, as intended by the
no_console_suspend parameter. [System resume is another problem, which
I'm working on].

Regards,

Peter Hurley (4):
  serial: core: Simplify console suspend logic in uart_suspend_port()
  serial: 8250_pnp: Override pnp disable for no_console_suspend
  PNP: Allow device to override ACPI device sleep
  serial: 8250_pnp: Override pnp suspend for no_console_suspend

 drivers/pnp/driver.c               |  2 +-
 drivers/pnp/pnpacpi/core.c         |  2 +-
 drivers/tty/serial/8250/8250_pnp.c | 61 +++++++++++++++++++++++++++++++-------
 drivers/tty/serial/serial_core.c   | 35 +++++++++++-----------
 include/linux/pnp.h                |  3 ++
 5 files changed, 72 insertions(+), 31 deletions(-)

-- 
2.1.3


             reply	other threads:[~2014-11-05 18:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 18:40 Peter Hurley [this message]
2014-11-05 18:40 ` [PATCH 1/4] serial: core: Simplify console suspend logic in uart_suspend_port() Peter Hurley
2014-11-05 18:40 ` [PATCH 2/4] serial: 8250_pnp: Override pnp disable for no_console_suspend Peter Hurley
2014-11-05 18:40 ` [PATCH 3/4] PNP: Allow device to override ACPI device sleep Peter Hurley
2014-11-05 22:28   ` Rafael J. Wysocki
2014-11-05 22:14     ` Peter Hurley
2014-11-05 18:40 ` [PATCH 4/4] serial: 8250_pnp: Override pnp suspend for no_console_suspend Peter Hurley
2014-11-05 18:45   ` Peter Hurley
2014-11-05 19:02   ` [PATCH v2 " Peter Hurley
2014-11-06 19:06 ` [PATCH 0/4] fix serial console suspend on PNP Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415212854-16944-1-git-send-email-peter@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).