From: Artem Bityutskiy <dedekind1@gmail.com>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: hujianyang <hujianyang@huawei.com>,
ezequiel.garcia@free-electrons.com,
Richard Weinberger <richard@nod.at>,
open list <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Thu, 06 Nov 2014 10:18:45 +0200 [thread overview]
Message-ID: <1415261925.958.177.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <54566692.10504@codeaurora.org>
On Sun, 2014-11-02 at 19:14 +0200, Tanya Brokhman wrote:
> >> + ubi_err(ubi, "self-check failed for PEB %d", pnum);
> >> + ubi_msg(ubi, "hex dump of the %d-%d region",
> >> + offset, offset + len);
> >> print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1, buf,
> len, 1);
> >> err = -EINVAL;
> >> error:
> >
> > Artem, I know you have tried to align the message code in different
> lines, maybe
> > you can check if you lose this one.
> >
>
> hmmm... not sure I understand what is wrong here....
It is more of a nit-pick, but we try to be consistent. Here is how we
align split messages:
ubi_msg(ubi, "blah",
XYZ)
and not
ubi_msg(ubi, "blah",
XYZ)
So we first use few tabs, and then some spaces to align. You use just
tabs. Sometimes the second line is aligned, sometimes it goes a bit
further.
prev parent reply other threads:[~2014-11-06 8:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 16:57 [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities Tanya Brokhman
2014-10-21 7:56 ` Artem Bityutskiy
2014-10-21 8:52 ` Tanya Brokhman
2014-10-22 6:06 ` hujianyang
2014-10-24 3:33 ` hujianyang
2014-10-24 3:39 ` hujianyang
2014-10-30 8:40 ` Artem Bityutskiy
2014-10-30 12:22 ` Tanya Brokhman
2014-11-02 17:14 ` Tanya Brokhman
2014-11-03 3:08 ` hujianyang
2014-11-03 7:15 ` Tanya Brokhman
2014-11-06 8:18 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415261925.958.177.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=hujianyang@huawei.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox