Re: [PATCH] drivers/core/of: Add symlink to device-tree from devices with an OF node

Benjamin Herrenschmidt
2014-11-19T02:52:45Z

On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
> Hi Rob,
>
> >> diff --git a/drivers/base/core.c b/drivers/base/core.c
> >> index 20da3ad..8c7b607 100644
> >> --- a/drivers/base/core.c
> >> +++ b/drivers/base/core.c
> >> @@ -493,6 +493,15 @@ static int device_add_attrs(struct device *dev)
> >> goto err_remove_dev_groups;
> >> }
> >>
> >> +#ifdef CONFIG_OF
> >> + if (dev->of_node) {
> >
> > if (IS_ENABLED(CONFIG_OF) && dev->of_node)
>
> struct device doesn't have an of_node member if !CONFIG_OF, so we'll
> need to disable this block in the preprocessor.

Actually that's no longer the case since 2.6.39 afaik :-)

Cheers,
Ben.